Sync GUI text-input changes #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swansontec
force-pushed
the
william/sync-gui-changes
branch
from
4497024 to
f912023
Compare
Jon-edge
requested changes
Jan 19, 2024
| @@ -60,6 +60,7 @@ export interface FilledTextInputProps extends SpaceProps { | |||
| showSpinner?: boolean | |||
| prefix?: string // Text input is left-left justified with a persistent prefix | |||
| suffix?: string // Text input is right-right justified with a persistent suffix | |||
| textsizeRem?: number | |||
There was a problem hiding this comment.
Where's autoCapitalize = props.secureTextEntry === true ? 'none' : undefined,? Was there a reason to omit this?
There was a problem hiding this comment.
Where's autoCapitalize = props.secureTextEntry === true ? 'none' : undefined,? Was there a reason to omit this?
There was a problem hiding this comment.
Outdated snapshot. It's updated now.
Jon-edge
approved these changes
Jan 19, 2024
swansontec
force-pushed
the
william/sync-gui-changes
branch
from
d270c2c to
d3c4c89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
none