Jon/desktop-modal-x #232
Merged
Jon/desktop-modal-x #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jon-edge
force-pushed
the
jon/desktop-modal-x
branch
from
aba28c0 to
e32fb97
Compare
Jon-edge
force-pushed
the
jon/desktop-modal-x
branch
from
e32fb97 to
53796ad
Compare
swansontec
requested changes
Feb 28, 2025
| @@ -49,6 +50,8 @@ export async function retryOnChallenge<T, C>(opts: { | |||
|
|
|||
| export const ChallengeModal = (props: Props) => { | |||
| const { bridge, challengeUri } = props | |||
| const { context } = useImports() | |||
| const { isDesktop } = context | |||
There was a problem hiding this comment.
This commit is using something that's not defined yet. Can we move it later in the PR (or just drop it as per the other comment)?
There was a problem hiding this comment.
Dropped the commit
Comment on lines
90
to
101
| {!isDesktop ? null : ( | ||
| <EdgeTouchableOpacity | ||
| style={styles.closeIconContainer} | ||
| onPress={handleCancel} | ||
| > | ||
| <AntDesignIcon | ||
| name="close" | ||
| color={theme.primaryText} | ||
| size={theme.rem(1.25)} | ||
| /> | ||
| </EdgeTouchableOpacity> | ||
| )} |
There was a problem hiding this comment.
It looks like the goal is to only show the close button on desktop? However, I think we need a close button on mobile too, since there is no other way to escape. The challenge HTML eats the scroll gesture, so swipe-to-close doesn't work, and there's no other exit button. Maybe we can just drop the commit.
There was a problem hiding this comment.
Dropped the commit
Minor difference: use `context` from GUI to determine `isDesktop` instead of the native dependency
Jon-edge
force-pushed
the
jon/desktop-modal-x
branch
from
53796ad to
42e12ac
Compare
|
I've updated the task with th expectations for |
swansontec
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor difference: use
contextfrom GUI to determineisDesktopinstead of the native dependencySpun off some other component sync tasks to https://app.asana.com/0/1200972350208303/1209521068045186
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
none