Skip to content

Commit

Permalink
Rename UpdateDots to OverrideDots
Browse files Browse the repository at this point in the history
This matches more nicely with all the variable/identifier names.
  • Loading branch information
samholmes authored and paullinator committed Jan 13, 2024
1 parent aada9f5 commit a90214b
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions src/components/common/SceneWrapper.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { EdgeInsets, useSafeAreaFrame, useSafeAreaInsets } from 'react-native-sa
import { useSceneDrawerState } from '../../state/SceneDrawerState'
import { useSelector } from '../../types/reactRedux'
import { NavigationBase } from '../../types/routerTypes'
import { UpdateDots } from '../../types/Theme'
import { OverrideDots } from '../../types/Theme'
import { maybeComponent } from '../hoc/maybeComponent'
import { NotificationView } from '../notification/NotificationView'
import { useTheme } from '../services/ThemeContext'
Expand Down Expand Up @@ -62,7 +62,7 @@ interface SceneWrapperProps {
keyboardShouldPersistTaps?: 'always' | 'never' | 'handled'

// Override existing background dots parameters
overrideDots?: UpdateDots
overrideDots?: OverrideDots

// Padding to add inside the scene border:
padding?: number
Expand Down
4 changes: 2 additions & 2 deletions src/components/ui4/DotsBackground.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import LinearGradient from 'react-native-linear-gradient'
import { Circle, Defs, G, RadialGradient, Stop, Svg } from 'react-native-svg'

import { useHandler } from '../../hooks/useHandler'
import { ThemeDot, UpdateDots } from '../../types/Theme'
import { OverrideDots, ThemeDot } from '../../types/Theme'
import { useTheme } from '../services/ThemeContext'

export interface AccentColors {
Expand All @@ -15,7 +15,7 @@ interface Props {
backgroundGradientColors?: string[]
backgroundGradientStart?: { x: number; y: number }
backgroundGradientEnd?: { x: number; y: number }
overrideDots?: UpdateDots
overrideDots?: OverrideDots
accentColors?: AccentColors
}

Expand Down
4 changes: 2 additions & 2 deletions src/types/Theme.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ export interface ThemeDot {
}

// Updates to dots. undefined keeps the dots, null deletes them
export type UpdateDots = Array<Partial<ThemeDot> | undefined | null>
export type OverrideDots = Array<Partial<ThemeDot> | undefined | null>

interface ThemeGradientParams {
colors: string[]
Expand Down Expand Up @@ -105,7 +105,7 @@ export interface Theme {
blurRadius: number
dotOpacity: number
dots: ThemeDot[]
assetOverrideDots: UpdateDots
assetOverrideDots: OverrideDots
}
assetBackgroundGradientColors: string[]
assetBackgroundGradientStart: { x: number; y: number }
Expand Down

0 comments on commit a90214b

Please sign in to comment.