Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Space component #5034

Merged
merged 8 commits into from
May 28, 2024
Merged

Change Space component #5034

merged 8 commits into from
May 28, 2024

Conversation

samholmes
Copy link
Contributor

@samholmes samholmes commented May 24, 2024 •
edited
Loading

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Requirements

If you have made any visual changes to the GUI. Make sure you have:

  • Tested on iOS device
  • Tested on Android device
  • Tested on small-screen device (iPod Touch)
  • Tested on large-screen device (tablet)

@samholmes samholmes changed the title Factor out margin rem props into useMarginRemStyle hook Change Space component May 24, 2024
swansontec
swansontec approved these changes May 25, 2024
View reviewed changes
Copy link
Contributor

@swansontec swansontec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, this is what we discussed.

@samholmes
Copy link
Contributor Author

/rebase

@samholmes samholmes enabled auto-merge May 27, 2024 21:38
@samholmes samholmes disabled auto-merge May 27, 2024 21:38
@github-actions github-actions bot force-pushed the sam/better-space-component branch from 3ee59b8 to 3d9b7d9 Compare May 27, 2024 21:39
@samholmes
Remove style prop from Space component
fa8de19
@samholmes
Add alignment props to SpaceProps
fceb415 
These are nearly the same as the boolean values for each of the current
space props (`top`, `bottom`, etc), except `alignRight` is the same as
`left={true}` because alignment props are negative rather than positive
when it comes to handling of space conceptually (pulling vs pushing of
space).
@samholmes
Use alignment props and remove boolean to other props in SpaceProps type
4c96706
@samholmes
Rename rem-based props in SpaceProps type
3ba9a26
@samholmes
Rename sideways prop to row
d85cedb
@samholmes
Change expand to do alignSelf in addition to flexGrow
f872993
@samholmes
Factor out margin rem props into useMarginRemStyle hook
c607ea4
@samholmes
Inline useSpaceStyle implementation into Space component
0429cbd
@samholmes samholmes enabled auto-merge May 28, 2024 18:13
@samholmes samholmes merged commit 8852ddd into develop May 28, 2024
2 checks passed
@samholmes samholmes deleted the sam/better-space-component branch May 28, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swansontec swansontec swansontec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samholmes @swansontec