Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Space component #5034

Merged
merged 8 commits into from
May 28, 2024
Merged

Change Space component #5034

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
fa8de19
Remove style prop from Space component
samholmes May 24, 2024
fceb415
Add alignment props to SpaceProps
samholmes May 24, 2024
4c96706
Use alignment props and remove boolean to other props in SpaceProps type
samholmes May 24, 2024
3ba9a26
Rename rem-based props in SpaceProps type
samholmes May 24, 2024
d85cedb
Rename `sideways` prop to `row`
samholmes May 24, 2024
f872993
Change `expand` to do `alignSelf` in addition to `flexGrow`
samholmes May 27, 2024
c607ea4
Factor out margin rem props into useMarginRemStyle hook
samholmes May 24, 2024
0429cbd
Inline useSpaceStyle implementation into Space component
samholmes May 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 11 additions & 13 deletions src/__tests__/components/__snapshots__/BalanceCard.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,19 +305,17 @@ exports[`BalanceCard should render with loading props 1`] = `
</View>
<View
style={
[
{
"alignItems": undefined,
"flex": undefined,
"flexDirection": "column",
"justifyContent": undefined,
"marginBottom": 11,
"marginLeft": 11,
"marginRight": 11,
"marginTop": 11,
},
undefined,
]
{
"alignItems": undefined,
"alignSelf": undefined,
"flexDirection": "column",
"flexGrow": undefined,
"justifyContent": undefined,
"marginBottom": 11,
"marginLeft": 11,
"marginRight": 11,
"marginTop": 11,
}
}
/>
<View
Expand Down
Loading
Loading