Retheme CreateWalletAccountSelectScene #4429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jon-edge
force-pushed
the
jon/hbar-activation-ui2
branch
from
c31024c
to
cd5bb2c
Compare
swansontec
approved these changes
Sep 4, 2023
Comment on lines
84
to
91
| let createdWallet: Promise<EdgeCurrencyWallet> | ||
| if (existingCoreWallet != null) { | ||
| createdWallet = renameAndReturnWallet(existingCoreWallet) | ||
| } else { | ||
| createdWallet = dispatch(createCurrencyWallet(accountName, selectedWalletType.walletType, fixFiatCurrencyCode(selectedFiat.value))).then(wallet => { | ||
| setIsCreatingWallet(false) | ||
| return wallet | ||
| }) |
There was a problem hiding this comment.
We can't have this logic at the top level of the component (maybe it needs useEffect or something). Maybe it's fine for now, though, since I see this code gets deleted in a later commit.
This value is always set in the current usage of these scenes
The scene has been updated to make it obvious what wallet is being activated with icons and wallet name. Spitting out the info of the wallet to be activated including the fiat type in the ugly text block is no longer necessary.
swansontec
force-pushed
the
jon/hbar-activation-ui2
branch
from
cd5bb2c
to
a6fe8bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: