Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require iOS 13 or greater #4468

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Require iOS 13 or greater #4468

merged 1 commit into from
Sep 21, 2023

Conversation

swansontec
Copy link
Contributor

@swansontec swansontec commented Sep 19, 2023

CHANGELOG

  • changed: Require iOS 13 or higher.

Dependencies

none

Requirements

If you have made any visual changes to the GUI. Make sure you have:

  • Tested on iOS device
  • Tested on Android device
  • Tested on small-screen device (iPod Touch)
  • Tested on large-screen device (tablet)

ios/Podfile Outdated
@@ -4,7 +4,7 @@ require_relative '../node_modules/@react-native-community/cli-platform-ios/nativ
# Edge addition to disable advertising ID collection:
$RNFirebaseAnalyticsWithoutAdIdSupport = true

platform :ios, '13.0'
platform :ios, '13.0' # min_ios_version_supported
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't use min_ios_version_supported it points to a react native variable (currently 12.4) and rnzcash requires 13.

@swansontec swansontec force-pushed the william/ios-13 branch 2 times, most recently from ec84a79 to 441bdd0 Compare September 21, 2023 20:49
@swansontec swansontec merged commit a9d5449 into develop Sep 21, 2023
2 checks passed
@swansontec swansontec deleted the william/ios-13 branch September 21, 2023 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants