Paul/new banxa #4476
Paul/new banxa #4476
Conversation
paullinator
force-pushed
the
paul/newBanxa
branch
3 times, most recently
from
2931480
to
b251601
Compare
| "paymentTypes": ["pix"], | ||
| "description": "Fee: 3-4%\nSettlement: 5 min - 24 hours", | ||
| "title": "Pix", | ||
| "// Do not enable until we have a Pix logo": "", |
There was a problem hiding this comment.
Didn't want to block this merge for 3.19 and we can easily patch later. I created a task for design to create one.
| @@ -37,7 +37,7 @@ export type FiatProviderQuoteErrorTypes = FiatProviderQuoteErrorTypesLimit | Fia | |||
| // amountType | |||
| export type FiatProviderQuoteError = | |||
| | { providerId: string; errorType: FiatProviderQuoteErrorTypesOther } | |||
| | { providerId: string; errorType: FiatProviderQuoteErrorTypesLimit; errorAmount?: number } | |||
| | { providerId: string; errorType: FiatProviderQuoteErrorTypesLimit; errorAmount?: number; displayCurrencyCode?: string } | |||
There was a problem hiding this comment.
direction would be useful to add here too
There was a problem hiding this comment.
Nevermind, saw the next commit
| @@ -107,12 +107,12 @@ export const amountQuoteFiatPlugin: FiatPluginFactory = async (params: FiatPlugi | |||
| // Pop up modal to pick wallet/asset | |||
| // TODO: Filter wallets according to fiats supported by allowed providers | |||
There was a problem hiding this comment.
This TODO seems outdated now. Looks like we're just going to always force a fiat
if required, regardless of the wallet fiat
There was a problem hiding this comment.
Not always. There are cases where a payment method can allow different fiats. ie Visa/MC
| @@ -206,17 +208,18 @@ export const amountQuoteFiatPlugin: FiatPluginFactory = async (params: FiatPlugi | |||
| goodQuotes.push(quote) | |||
| } | |||
|
|
|||
| const noQuoteText = direction === 'buy' ? lstrings.fiat_plugin_buy_no_quote : lstrings.fiat_plugin_sell_no_quote | |||
There was a problem hiding this comment.
Move error string logic into getBestError/getErrorText
There was a problem hiding this comment.
This would duplicate the logic in the two funcs getBestError/getErrorText. Where it is now keeps the logic consistent.
src/plugins/gui/amountQuotePlugin.ts
Outdated
| @@ -137,7 +137,7 @@ export const amountQuoteFiatPlugin: FiatPluginFactory = async (params: FiatPlugi | |||
| showUi.enterAmount({ | |||
| headerTitle: isBuy ? sprintf(lstrings.fiat_plugin_buy_currencycode, currencyCode) : sprintf(lstrings.fiat_plugin_sell_currencycode_s, currencyCode), | |||
| initState: { | |||
| value1: '500' | |||
| value1: defaultFiatAmount ?? '500' | |||
There was a problem hiding this comment.
Let's move the default assignment to the top
| lockUriPath: true, | ||
| nativePlugin: amountQuoteFiatPlugin, | ||
| forceFiatCurrencyCode: 'iso:TRY', | ||
| defaultFiatAmount: '2000', |
There was a problem hiding this comment.
Why is this amount so much higher than our normal 500?
There was a problem hiding this comment.
Turkish Lira is worth a LOT less
There was a problem hiding this comment.
500 Lira doesn't meet the minimum purchase
There was a problem hiding this comment.
Maybe we can do a TODO to have a conversion mechanism for default fiats if we ever do fiat-fiat rates
paullinator
force-pushed
the
paul/newBanxa
branch
2 times, most recently
from
9dc75e2
to
b6c39ad
Compare
paullinator
force-pushed
the
paul/newBanxa
branch
from
b6c39ad
to
7764395
Compare
|
/rebase |
Replace some wyre plugin check with dummy plugin check to retain code logic for future use.
Not all are enabled in this commit
This bypasses the wallet currency code so certain payment types can be ensured to use the right currency code filters (ie sepa)
Remove Poli as it is being deprecated
Retaining component code for rewards card as we expect to re-use that in the future.
This requires allowing the min/max limit error to specify the currencycode as Banxa only supports limits in the fiat amount, not the crypto amount
The original index of paymenttype would duplicate payment methods of the same payment type to stomp on top of each other. The 'id' is the true unique identifier.
Banxa's `api/payment-methods` does not return sell payment methods unless a source asset is specified. Even then it only returns paymentmethod objects which specify that one asset as allowed. We now query the sell payment methods at getSupportedAssets for BTC, then possibly again in getQuote if the crypto asset isn't in the cache.
paullinator
force-pushed
the
paul/newBanxa
branch
from
7764395
to
a78925c
Compare
CHANGELOG
noneDependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: