Dynamic TC Savers pools. Was: Stable savers #4479
Conversation
paullinator
force-pushed
the
paul/stableSavers
branch
from
df2e660
to
c83c259
Compare
| }) | ||
| policiesInitialized = true | ||
| } catch (e) { | ||
| console.log('Error initializing Thorchain Savers policies', String(e)) |
There was a problem hiding this comment.
Would this frequently happen? If not, seems useful to promote this to a console warn or error
There was a problem hiding this comment.
console.warn is annoying in that it shows as a yellow box in the debugger. It's not critical as it can happen if there is a networking failure
|
Do not merge. found a bug that will need a fixup |
paullinator
force-pushed
the
paul/stableSavers
branch
3 times, most recently
from
491e07f
to
f30bef3
Compare
|
This implementation will not work as I've been notified by TC devs that we need to use a smart contract for token deposits. This requires a major overhaul to make the code similar to the swap code that uses memos. Closing this task as a new one will be estimated and planned out. |
paullinator
force-pushed
the
paul/stableSavers
branch
2 times, most recently
from
7ef8b2e
to
64a1f90
Compare
paullinator
changed the title
paullinator
force-pushed
the
paul/stableSavers
branch
from
64a1f90
to
5fdf02a
Compare
paullinator
force-pushed
the
paul/stableSavers
branch
from
5fdf02a
to
69809d6
Compare
| @@ -197,7 +197,7 @@ function EditTokenSceneComponent(props: Props) { | |||
| * In the future this scene may need to handle other weird networks | |||
| * where the networkLocation has other contents. | |||
| */ | |||
| const asMaybeContractLocation = asMaybe(asObject({ contractAddress: asString })) | |||
| export const asMaybeContractLocation = asMaybe(asObject({ contractAddress: asString })) | |||
There was a problem hiding this comment.
Might be a good time to move /aave/cleaners/asEthTokenContractAddress.ts to a
common location and add asMaybeContractLocation to it
There was a problem hiding this comment.
Will do for the full Thorchain Savers with token task.
paullinator
force-pushed
the
paul/stableSavers
branch
from
5bfe115
to
62c61cb
Compare
|
/rebase |
|
/rebase_autosquash |
paullinator
force-pushed
the
paul/stableSavers
branch
from
62c61cb
to
6a03b01
Compare
CHANGELOG
noneDependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: