Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Receive: Fix Balance Text Overflow #4481

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Receive: Fix Balance Text Overflow #4481

merged 1 commit into from
Sep 25, 2023

Conversation

Jon-edge
Copy link
Collaborator

@Jon-edge Jon-edge commented Sep 21, 2023 •
edited
Loading

image

CHANGELOG

  • fixed: Possible balance text overflow in Receive scene

Dependencies

none

Requirements

If you have made any visual changes to the GUI. Make sure you have:

  • Tested on iOS device
  • Tested on Android device
  • Tested on small-screen device (iPod Touch)
  • Tested on large-screen device (tablet)

@paullinator
Copy link
Member

/rebase

swansontec
swansontec approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@swansontec swansontec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Any time we put text in a horizontal container, it needs to be flexible.

@swansontec swansontec merged commit 6f41c5e into develop Sep 25, 2023
2 checks passed
@swansontec swansontec deleted the jon/fix/rcv-amount-len branch September 25, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swansontec swansontec swansontec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jon-edge @paullinator @swansontec