Transparent Header/Tab Bar #4648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samholmes
force-pushed
the
sam/transparent-tabbar
branch
6 times, most recently
from
4b36b5a to
752abc9
Compare
swansontec
requested changes
Jan 1, 2024
samholmes
force-pushed
the
sam/transparent-tabbar
branch
from
752abc9 to
a52ab67
Compare
swansontec
approved these changes
Jan 4, 2024
swansontec
approved these changes
Jan 4, 2024
| * Also draws a common gradient background under the scene. | ||
| * | ||
| * If the children are normal React elements, then the wrapper will apply | ||
| * padding needing to avoid the safe area inset and header/tab-bar/etc. |
samholmes
force-pushed
the
sam/transparent-tabbar
branch
from
a52ab67 to
50bb216
Compare
samholmes
force-pushed
the
sam/transparent-tabbar
branch
from
50bb216 to
c0aa9f7
Compare
This is a change copied from NotificationSceneWrapper.
The motivation for this change is to make the SceneWrapper implementation reasonable (as in easy to reason about). We achieve this with a `maybeComponent` HOC that will either render the given component or a React.Fragment component depending on a `when` prop.
samholmes
force-pushed
the
sam/transparent-tabbar
branch
from
c0aa9f7 to
48f6772
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have:
Simulator.Screen.Recording.-.iPhone.14.-.2023-12-21.at.17.23.39.mp4