Cleanups for new core #4653
Merged
Cleanups for new core #4653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samholmes
approved these changes
Dec 23, 2023
There was a problem hiding this comment.
The type is called WalletListResult, so perhaps a change to the commit message is all that is needed to clarify this.
This is exactly the same as the core type.
The old flip input required this information, but it is no longer necessary.
Also remove the unused `pluginId` property.
swansontec
force-pushed
the
william/cleanups
branch
from
144e301 to
8fd7595
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to separate the two cases where
tokenId: undefinedmeans "parent currency" vs. when it means "we don't have this information".For the
GuiCurrencyInfocase, we just make tokenId mandatory. For theWalletListResult, I used a discriminated union to remove tokenId from cases where it's not relevant.CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
These are the preparatory fixes for #4641, as part of my PR review.
Requirements
If you have made any visual changes to the GUI. Make sure you have: