Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FIO handle modal #4674

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Update FIO handle modal #4674

merged 1 commit into from
Jan 10, 2024

Conversation

Jon-edge
Copy link
Collaborator

@Jon-edge Jon-edge commented Jan 3, 2024

image

  • Use ButtonsViewUi4
  • Change green word highlight location

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

#4673

Requirements

If you have made any visual changes to the GUI. Make sure you have:

  • Tested on iOS device
  • Tested on Android device
  • Tested on small-screen device (iPod Touch)
  • Tested on large-screen device (tablet)

Copy link
Member

@paullinator paullinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where did you change the images?

@Jon-edge
Copy link
Collaborator Author

Jon-edge commented Jan 8, 2024

Where did you change the images?

They are changed on the CDN in a prior PR. From the spec:
image

@paullinator
Copy link
Member

Per discussion. Change the image name so UI3 users get the same image as before and make UI4 images have a different name.

@Jon-edge Jon-edge force-pushed the jon/ui4/update-fio-modal branch from 863d91f to bb7d085 Compare January 9, 2024 03:24
- Use ButtonsViewUi4
- Change green word highlight location
@Jon-edge Jon-edge enabled auto-merge January 10, 2024 02:53
@Jon-edge Jon-edge force-pushed the jon/ui4/update-fio-modal branch from bb7d085 to 2b6db40 Compare January 10, 2024 02:53
@Jon-edge Jon-edge merged commit f02bd44 into develop Jan 10, 2024
2 checks passed
@Jon-edge Jon-edge deleted the jon/ui4/update-fio-modal branch January 10, 2024 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants