UI4: Replace Legacy Tile & Card #4681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullinator
force-pushed
the
jon/ui4/replace-tile-card
branch
from
24648b4
to
c401850
Compare
paullinator
requested changes
Jan 8, 2024
Jon-edge
force-pushed
the
jon/ui4/replace-tile-card
branch
5 times, most recently
from
217ba2c
to
9b579ed
Compare
paullinator
approved these changes
Jan 10, 2024
- Simple find/replace for Tile. - Rename type->rightButtonType - Replace "static" -> "none" where applicable. Fully removed rightButtonType="none/static" if no press handler since that's redundant. - TODO's have been noted at the top of some files to ensure it works without specific 'contentPadding'
Jon-edge
force-pushed
the
jon/ui4/replace-tile-card
branch
from
9b579ed
to
a7c5e64
Compare
Simple find/replace of jsx and imports
HomeCardUi4 and any future evenly tiled layouts is the only case in which we really need flex: 1.
No design spec so just make it similar to UI4 for now.
Needs more thought on how we should group/rearrange this, but it's a start.
Punting updates to RowUi4 to support these new row types to a future update. This looks good enough for now pending a general UI4 scene redesign.
Needs redesign for new organization of the elements. Perhaps 2 labeled sections for country and providers, allowing providers to be grouped into one card, or some other way to distinguish region selection from the other tappable items.
Leaving naked MainButtons for now, simply changing the type to primary.
Allow CardUi4 to control styling of an icon when just a uri is given. Icon will be the same size as original IconTile.
Jon-edge
force-pushed
the
jon/ui4/replace-tile-card
branch
from
a7c5e64
to
b12a626
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
#4676
#4673
Requirements
If you have made any visual changes to the GUI. Make sure you have: