Paul/fix tagging #4691
Merged
Paul/fix tagging #4691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jon-edge
reviewed
Jan 10, 2024
Comment on lines
+626
to
+637
| "transaction_details_swap_network_fee": "Swap Network Fee", | ||
| "transaction_details_swap_order_cancel": "Swap Order Canceled", | ||
| "transaction_details_swap_order_post": "Swap Order Opened", | ||
| "transaction_details_swap_order_fill": "Swap Order Filled", | ||
| "transaction_details_claim": "Claim Staked Funds", | ||
| "transaction_details_claim_order": "Claim Order", | ||
| "transaction_details_stake": "Stake Funds", | ||
| "transaction_details_stake_order": "Stake Order", | ||
| "transaction_details_stake_network_fee": "Stake Network Fee", | ||
| "transaction_details_transfer_network_fee": "Transfer Network Fee", | ||
| "transaction_details_unstake": "Unstake Funds", | ||
| "transaction_details_unstake_network_fee": "Unstake Network Fee", |
There was a problem hiding this comment.
We can probably safely do "%$1s Network Fee" for these
There was a problem hiding this comment.
Technically the translations might change the order of the words so I would say best not to
Jon-edge
approved these changes
Jan 10, 2024
paullinator
force-pushed
the
paul/fixTagging
branch
2 times, most recently
from
fb20a63
to
4ba48e5
Compare
paullinator
force-pushed
the
paul/fixTagging
branch
2 times, most recently
from
a83343e
to
b6a19e4
Compare
paullinator
force-pushed
the
paul/fixTagging
branch
from
b6a19e4
to
e8ead3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
EdgeApp/edge-core-js#580
Requirements
If you have made any visual changes to the GUI. Make sure you have: