Jon/ui4/fix/post-upgrade-styling #4698
Conversation
Jon-edge
force-pushed
the
jon/ui4/fix/post-upgrade-styling
branch
from
59b6f20 to
8f91e61
Compare
| @@ -80,7 +80,7 @@ export const RowUi4 = (props: Props) => { | |||
| const content = ( | |||
| <> | |||
| {icon == null ? null : icon} | |||
| <View style={styles.content}> | |||
| <View style={[styles.content, rightButtonVisible ? styles.tappableIconMargin : styles.fullWidth]}> | |||
There was a problem hiding this comment.
This change makes me nervous. It's possibility for regression is high as this is a very reused component. Please provide screenshots of everywhere RowUi4 is used to verify it hasn't broken anything.
There was a problem hiding this comment.
All I'm doing here is removing the reliance on an empty view to deal with the content spacing to accomadate the absolutely positioned tappable icon as it was causing problems with some legacy styling for custom row children.
Provided various example screenshots
| onPress={() => bridge.resolve(alpha)} | ||
| /> | ||
| <CardUi4 marginRem={[0.5, 0, 0.5, 0]}> | ||
| <RowUi4 title={name} body={alpha} icon={<FastImage source={source} style={styles.image} />} onPress={() => bridge.resolve(alpha)} /> |
There was a problem hiding this comment.
Using RowUi4 changes the design altogether. These rows do not mimic the design of the original Tile which RowUi4 uses.
The design should have the top Text is primaryText color and rem=1 while the second row is smaller with the secondary text color.
There was a problem hiding this comment.
Reverted, retaining original SelectableRow styling.
Jon-edge
force-pushed
the
jon/ui4/fix/post-upgrade-styling
branch
5 times, most recently
from
84566e8 to
487e4c0
Compare
| {/* HACK: Keeping the iconContainer instead of CardUi4's built-in icon prop because the prop's behavior is inconsistent in legacy use cases */} | ||
| <View style={styles.iconContainer}>{icon}</View> | ||
| <View style={styles.textContainer}> | ||
| <EdgeText numberOfLines={1} disableFontScaling> |
There was a problem hiding this comment.
why did you add disableFontScaling. This would help with long country names
There was a problem hiding this comment.
Madison's request
src/locales/en_US.ts
Outdated
| @@ -619,6 +619,8 @@ const strings = { | |||
| title_add_token: 'Add Token', | |||
| title_password_recovery: 'Password Recovery', | |||
| title_plugin_buy: 'Buy Cryptocurrency', | |||
| title_select_region: 'Select Region:', | |||
Jon-edge
force-pushed
the
jon/ui4/fix/post-upgrade-styling
branch
from
487e4c0 to
8d30f83
Compare
Jon-edge
force-pushed
the
jon/ui4/fix/post-upgrade-styling
branch
from
8d30f83 to
a54dd9d
Compare
Removed chevron. Removed text shrinking per new design spec
- Fix allowing the wallet name to take up as much space as possible.
- Remove chevrons - Left justify Powered By - Add CTA headers. Intentionally did not reuse old "Select your region" string because it's not capitalized in a way that looks like a title.
Jon-edge
force-pushed
the
jon/ui4/fix/post-upgrade-styling
branch
from
a54dd9d to
9f85799
Compare
TextInput spacing for the modal not addressed in this PR.
Sanity check (SplitRowsView styling update)
Sanity check (RowUi4):
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: