Text Input Fixes #4699
Merged
Text Input Fixes #4699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samholmes
force-pushed
the
sam/input-fixes
branch
from
cb550b9
to
622485a
Compare
paullinator
requested changes
Jan 11, 2024
| @@ -273,8 +273,7 @@ export const FilledTextInput = React.forwardRef<FilledTextInputRef, FilledTextIn | |||
| </Container> | |||
| </TouchableWithoutFeedback> | |||
| <MessagesContainer> | |||
| {valid ? <Message>{valid}</Message> : null} | |||
| {error ? <Message danger>{error}</Message> : null} | |||
| <Message danger={error != null}>{valid || error || null}</Message> | |||
samholmes
force-pushed
the
sam/input-fixes
branch
from
622485a
to
4e7d58c
Compare
paullinator
approved these changes
Jan 12, 2024
Introduces DEV_TAB env config to enable or disable the devTab in the MenuTabs. In the future, this config should be a string which takes the screen name to load as the devTab.
samholmes
force-pushed
the
sam/input-fixes
branch
from
4e7d58c
to
3447119
Compare
This should improve render performance for all Space components and components which implement SpaceProps.
This allows for the color interpolation to actually animate.
Color is an animated style property for the placeholder text.
samholmes
force-pushed
the
sam/input-fixes
branch
from
3447119
to
eaef9fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for the color interpolation to actually animate.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: