Add Coreum native staking #4704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
peachbits
commented
Jan 11, 2024
•
peachbits
commented
- To see the specific tasks where the Asana app for GitHub is being used, see below:
- https://app.asana.com/0/0/1205910632157440
samholmes
reviewed
Jan 12, 2024
globals.js
Outdated
| @@ -0,0 +1 @@ | |||
| global.TextEncoder = require('text-encoding').TextEncoder | |||
There was a problem hiding this comment.
Is TextEncoder not supported by Hermes?
There was a problem hiding this comment.
Add comment:
// Remove when Hermes supports TextEncoder API natively: https://github.com/facebook/hermes/issues/948
| parentCurrencyCode: 'COREUM', | ||
| hideUnstakeAction: true, | ||
| adapterConfig: { | ||
| ...commonAdaptorConfig, |
There was a problem hiding this comment.
Unneeded and preferably unwanted.
| const { unsignedTransaction } = txs[i] | ||
| if (unsignedTransaction == null) continue | ||
|
|
||
| const signedTx = await wallet.signMessage(unsignedTransaction) |
There was a problem hiding this comment.
wallet.signMessage will correctly sign the transaction? I didn't know this would work.
samholmes
reviewed
Jan 17, 2024
Comment on lines
368
to
372
| // case 'unstaked': | ||
| // case 'unlocking': | ||
| // case 'locked': | ||
| // case 'available': | ||
| // case 'preparing': |
There was a problem hiding this comment.
Cleanup these and the other comments
peachbits
force-pushed
the
matthew/coreumStaking
branch
2 times, most recently
from
606a06f
to
bb38691
Compare
samholmes
approved these changes
Jan 22, 2024
peachbits
force-pushed
the
matthew/coreumStaking
branch
2 times, most recently
from
13134ce
to
0c6ae34
Compare
peachbits
force-pushed
the
matthew/coreumStaking
branch
from
4c20ad7
to
6755620
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.