Fix and Tweak Animations #4710
Fix and Tweak Animations #4710
Conversation
paullinator
changed the title
paullinator
force-pushed
the
paul/fixWelcomeAnims
branch
3 times, most recently
from
859a5d7
to
d70635a
Compare
src/components/common/EdgeAnim.tsx
Outdated
| * anim => disable animation but still render a container view | ||
| * view => render the children with no container view | ||
| * */ | ||
| disable?: 'anim' | 'view' |
There was a problem hiding this comment.
Why is this an enumeration? I think it's clear through the API and component name that a boolean true here means just the lack of animation.
In general I think it's clearer to have named value enums, though the rest of our app has a pattern of disable being a boolean flag. One less thing to hover would be nice and usage would have less code.
If there's future plans to have more disable configuration types then a different prop name seems more appropriate
| @@ -81,8 +81,9 @@ const CoinRankingComponent = (props: Props) => { | |||
| const key = `${index}-${item}-${rank}-${currencyCode}-${lastUsedFiat}` | |||
| debugLog(LOG_COINRANK, `renderItem ${key.toString()}`) | |||
|
|
|||
| const disable = index >= MAX_LIST_ITEMS_ANIM ? 'view' : undefined | |||
There was a problem hiding this comment.
If disable we're just a boolean this would simply be const disable = index >= MAX_LIST_ITEMS_ANIM
There was a problem hiding this comment.
As mentioned above. There are necessarily two types of view disables so that we don't render extra Views if not needed.
Disable layout animations that are also gesture animated. These are broken on Android
paullinator
force-pushed
the
paul/fixWelcomeAnims
branch
from
d70635a
to
46cab82
Compare
|
/rebase |
github-actions
bot
force-pushed
the
paul/fixWelcomeAnims
branch
from
46cab82
to
01a8a3f
Compare
paullinator
force-pushed
the
paul/fixWelcomeAnims
branch
from
01a8a3f
to
fc7c885
Compare
Disable layout animations that are also gesture animated. These are broken on Android
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: