Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugsnag source maps #4712

Merged
merged 2 commits into from
Jan 15, 2024
Merged

Fix bugsnag source maps #4712

merged 2 commits into from
Jan 15, 2024

Conversation

paullinator
Copy link
Member

@paullinator paullinator commented Jan 15, 2024

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Requirements

If you have made any visual changes to the GUI. Make sure you have:

  • Tested on iOS device
  • Tested on Android device
  • Tested on small-screen device (iPod Touch)
  • Tested on large-screen device (tablet)

@paullinator paullinator force-pushed the paul/fixMaps2 branch 3 times, most recently from 9b1f4fc to e97faf7 Compare January 15, 2024 07:30
Copy link
Contributor

@swansontec swansontec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One teeny change is needed.

@@ -19,11 +19,11 @@ buildscript {
}
dependencies {
classpath("com.android.tools.build:gradle:7.4.1")
classpath("com.bugsnag:bugsnag-android-gradle-plugin:7.+")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to stay in the "Edge additions" section, so we know not to delete it the next time we do a React Native upgrade. If that doesn't work, then it at least needs a comment.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This actually got moved by the automated bugsnag script that was recommended that we use to install bugsnag. Given that it wasn't manually added (sort of), should I still move it back?

Use bugsnag-source-maps to upload map file for android
Use npx @bugsnag/react-native-cli init to install and configure BugSnag for ios map file upload
helps troubleshoot broken builds
@paullinator paullinator merged commit aebdaf4 into develop Jan 15, 2024
2 checks passed
@paullinator paullinator deleted the paul/fixMaps2 branch January 15, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants