Tweak FilledTextInput spacing #4716
Conversation
paullinator
force-pushed
the
paul/fixTextInput
branch
from
edba2f7 to
6373eed
Compare
|
paullinator
force-pushed
the
paul/fixTextInput
branch
3 times, most recently
from
7e548e0 to
e604f3a
Compare
paullinator
force-pushed
the
paul/fixTextInput
branch
2 times, most recently
from
d4065e0 to
b40370e
Compare
|
paullinator
force-pushed
the
paul/fixTextInput
branch
from
b40370e to
468f905
Compare
|
Ignore blue background. That was removed in the fixup |
| @@ -347,6 +345,8 @@ const InnerContainer = styled(Animated.View)<{ | |||
| hasPlaceholder: boolean | |||
| }>(theme => ({ hasPlaceholder, focusValue }) => { | |||
| const rem = theme.rem(1) | |||
|
|
|||
| // Need 2 pixels of shift given a 16 point rem settings | |||
There was a problem hiding this comment.
Still it's weird that you need to shift the container two pixels to the right on Android. Why would Android be rendering views differently?
There was a problem hiding this comment.
Cant tell you why but that seems to be the case with text inputs vs text views
There was a problem hiding this comment.
This is an Animated.View not a TextInput
There was a problem hiding this comment.
Yes, but it's the view of the TextInput
| @@ -208,9 +209,9 @@ export const FilledTextInput = React.forwardRef<FilledTextInputRef, FilledTextIn | |||
| const InputComponent = numeric ? StyledNumericInput : StyledAnimatedTextInput | |||
|
|
|||
| return ( | |||
| <> | |||
| <View style={spaceStyle}> | |||
There was a problem hiding this comment.
Why was this done? Isn't the whole point of using the space props within the component to avoid the extra view? If this is our result, we might as well just use a component around the input when we want the space props, at least then we'd only be rendering an extra view when we actually want the space.
There was a problem hiding this comment.
This fixes the bug where extra margin was added by a space prop but inbetween the input box and the bottom right message. it's too late in the sprint to make a change that would break the API given how many places use this component is used
There was a problem hiding this comment.
In case, we can just use a Space component and pass the space props directly to it. Also, override sideways to false.
|
/rebase |
paullinator
force-pushed
the
paul/fixTextInput
branch
from
468f905 to
75f5dfa
Compare
Also add more test cases to InputTester
paullinator
force-pushed
the
paul/fixTextInput
branch
from
75f5dfa to
1326529
Compare
Also add more test cases to InputTester
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: