UI4: Modal Post-Migration Fixes #4718
Merged
Commits on Jan 18, 2024
-
- Fix blur positioning for fullscreen modals - Remove extra view for rounding BlurView bounds - Remove extra view around non-scrolling children. This allows `flex: 1` children without a modal-wide scroll to work as they did before. - Move title handling into the modal itself.
-
Partially "nuggetize" ModalParts
This is an interim quick fix before we just fully remove dependencies on ModalParts. There's no need to retain anything from ModalParts anymore once fully migrated to UI4 - they weren't really doing anything special to begin with.
-
Quick hack fix to kind of obtain the result of ButtonsViewUi4 with consistent button widths. An additional audit will need to be performed to determine which buttons should be primary/secondary/tertiary before we can migrate them to ButtonsViewUi4 and enforce our rule of not having multiple buttons of the same type in a column layout.
-
Pull ModalTitle into the title prop of Ui4
Some modals have inconsistent centered titles and this change unifies them all. Making this change will allow us to easily center all titles later if that's what we prefer.
-
Needs a redesign. We have a bunch of empty title space here, and at the same time we can't push the FlipInput card all the way up there because then the X button would have weird alignment over the inner FlipInput card
-
-
-
-
-
-
-
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.