Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React Native v0.74 #5035

Merged
merged 3 commits into from
May 27, 2024
Merged

React Native v0.74 #5035

merged 3 commits into from
May 27, 2024

Conversation

swansontec
Copy link
Contributor

@swansontec swansontec commented May 24, 2024

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

EdgeApp/react-native-zcash#54
EdgeApp/react-native-piratechain#12

Requirements

If you have made any visual changes to the GUI. Make sure you have:

  • Tested on iOS device
  • Tested on Android device
  • Tested on small-screen device (iPod Touch)
  • Tested on large-screen device (tablet)

@swansontec swansontec force-pushed the william/rn74 branch 3 times, most recently from b17957d to 8b2ae21 Compare May 27, 2024 17:44
See the CocoaPods 1.5.0 release notes for context: https://blog.cocoapods.org/CocoaPods-1.5.0/

With this change, we no longer need to wac-a-mole individual places where a Swift pod depends on an Objective-C pod. Instead, we opt all libraries into using the stricter Objective-C import paths. There are no build breaks with this turned on, so it seems like all the pods we depend are already using header paths correctly.
This compiles our pods into a framework, instead of a static library (.a). This makes the build more stable, but it wasn't compatible with Flipper. Fortunately, we don't use Flipper anymore.
@swansontec swansontec enabled auto-merge May 27, 2024 22:15
@swansontec swansontec merged commit 8fb4dba into develop May 27, 2024
2 checks passed
@swansontec swansontec deleted the william/rn74 branch May 27, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants