Paul/coinhub fixes2 #5341
Merged
Paul/coinhub fixes2 #5341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jon-edge
approved these changes
Nov 4, 2024
| @@ -830,9 +830,12 @@ const strings = { | |||
|
|
|||
| buy_crypto_modal_title: 'Wallet Empty', | |||
| buy_crypto_modal_message: 'Your %s wallet is empty. Would you like to buy %s or exchange another crypto into %s?', | |||
| buy_crypto_modal_message_no_exchange_s: 'Your %s wallet is empty. Would you like to buy %s?', | |||
There was a problem hiding this comment.
buy_crypto_modal_message_no_exchange_1s
There was a problem hiding this comment.
Also, does this need to go through getUkCompliantString()?
There was a problem hiding this comment.
For now no need as it wasnt requested
paullinator
force-pushed
the
paul/coinhubFixes2
branch
from
a092b17
to
c48f22b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: