Earn scene loop handling adjustments #5344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jon-edge
force-pushed
the
matthew/earn-scene-error
branch
from
5b9dc05
to
3e41fbc
Compare
peachbits
force-pushed
the
matthew/earn-scene-error
branch
from
3e41fbc
to
896cf7a
Compare
Jon-edge
approved these changes
Nov 8, 2024
src/plugins/stake-plugins/types.ts
Outdated
|
|
||
| if (wallet != null) { | ||
| out = out.filter(policy => [...policy.rewardAssets, ...policy.stakeAssets].some(asset => asset.pluginId === wallet.currencyInfo.pluginId)) | ||
| if (pluginId != null) { |
There was a problem hiding this comment.
wallet is still part of this StakePolicyFilterType. Should still support the
original behavior here by extracting the pluginId from the wallet, or else it's
confusing that there's a noop prop on the filter when you call filterStakePolicies
| } | ||
|
|
||
| return filteredPolicies | ||
| return filterStakePolicies(policies, filter) |
It isn't necessary to slow down use of workflowUtils by calling this method
peachbits
force-pushed
the
matthew/earn-scene-error
branch
from
896cf7a
to
2fa42a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: