Use const for start dates

EdgeApp · Mar 30, 2024 · c58fa71 · c58fa71
1 parent 0ba1001
commit c58fa71
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,7 @@
 
 ## Unreleased
 
+- added: Add Lifi reporting
 - changed: Paginate caching engine to prevent timeouts
 - changed: Create caching engine 'initialized' document entry for each app:partner pair
 

diff --git a/src/partners/banxa.ts b/src/partners/banxa.ts
@@ -12,6 +12,7 @@ import crypto from 'crypto'
 import { Response } from 'node-fetch'
 
 import {
+  EDGE_APP_START_DATE,
   PartnerPlugin,
   PluginParams,
   PluginResult,
@@ -22,7 +23,7 @@ import { datelog, retryFetch, smartIsoDateFromTimestamp, snooze } from '../util'
 
 export const asBanxaParams = asObject({
   settings: asObject({
-    latestIsoDate: asOptional(asString, '2018-01-01T00:00:00.000Z')
+    latestIsoDate: asOptional(asString, EDGE_APP_START_DATE)
   }),
   apiKeys: asObject({
     apiKey: asString,

diff --git a/src/partners/letsexchange.ts b/src/partners/letsexchange.ts
@@ -9,6 +9,7 @@ import {
 } from 'cleaners'
 
 import {
+  EDGE_APP_START_DATE,
   PartnerPlugin,
   PluginParams,
   PluginResult,
@@ -19,7 +20,7 @@ import { datelog, retryFetch, smartIsoDateFromTimestamp } from '../util'
 
 export const asLetsExchangePluginParams = asObject({
   settings: asObject({
-    latestIsoDate: asOptional(asString, '2018-01-01T00:00:00.000Z')
+    latestIsoDate: asOptional(asString, EDGE_APP_START_DATE)
   }),
   apiKeys: asObject({
     affiliateId: asOptional(asString),

diff --git a/src/partners/lifi.ts b/src/partners/lifi.ts
@@ -10,6 +10,7 @@ import {
 
 import {
   asStandardPluginParams,
+  EDGE_APP_START_DATE,
   PartnerPlugin,
   PluginParams,
   PluginResult,
@@ -18,6 +19,7 @@ import {
 } from '../types'
 import { datelog, retryFetch, smartIsoDateFromTimestamp, snooze } from '../util'
 
+const PLUGIN_START_DATE = '2023-01-01T00:00:00.000Z'
 const asStatuses = asMaybe(asValue('DONE'), 'other')
 const asToken = asObject({
   // address: asString,
@@ -85,8 +87,8 @@ export async function queryLifi(
   const { apiKey } = apiKeys
   let { latestIsoDate } = settings
 
-  if (latestIsoDate === '2018-01-01T00:00:00.000Z') {
-    latestIsoDate = new Date('2023-01-01T00:00:00.000Z').toISOString()
+  if (latestIsoDate === EDGE_APP_START_DATE) {
+    latestIsoDate = new Date(PLUGIN_START_DATE).toISOString()
   }
 
   let lastCheckedTimestamp = new Date(latestIsoDate).getTime() - QUERY_LOOKBACK

diff --git a/src/types.ts b/src/types.ts
@@ -9,6 +9,9 @@ import {
   asValue
 } from 'cleaners'
 
+/** Earliest date that transactions may show in Edge */
+export const EDGE_APP_START_DATE = '2018-01-01T00:00:00.000Z'
+
 export const asPluginParams = asObject({
   settings: asMap((raw: any): any => raw),
   apiKeys: asMap((raw: any): any => raw)
@@ -71,7 +74,7 @@ export const asDbCurrencyCodeMappings = asObject({
 
 export const asStandardPluginParams = asObject({
   settings: asObject({
-    latestIsoDate: asOptional(asString, '2018-01-01T00:00:00.000Z')
+    latestIsoDate: asOptional(asString, EDGE_APP_START_DATE)
   }),
   apiKeys: asObject({
     apiKey: asOptional(asString)