Paul/maya #193
Open
Paul/maya #193
+274
−553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samholmes
requested changes
Nov 11, 2024
src/partners/thorchain.ts
Outdated
| srcAddress = txIn.address | ||
| break | ||
| } else { | ||
| if (pools.length === 1) { |
There was a problem hiding this comment.
It doesn't really seem to make sense to have this condition in the txIn.coins loop.
package.json
Outdated
There was a problem hiding this comment.
What's the reason for reverting?
paullinator
force-pushed
the
paul/maya
branch
2 times, most recently
from
5c20bc9
to
9d7fdc0
Compare
- xClientId helps prevent timeouts - snooze to also help prevent timeouts - use affiliateAddress to filter txs not created in app
Original code was missing logic to handle txs where RUNE or CACAO were the assets being swapped.
This reverts commit a964ae5.
paullinator
force-pushed
the
paul/maya
branch
from
9d7fdc0
to
84c40f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
none