0xGasless Plugin #196
Open
0xGasless Plugin #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This upgrade gives us more information about the raw value's type when a cleaner fails. Very useful.
paullinator
requested changes
Jan 15, 2025
src/partners/0xgasless.ts
Outdated
| | 'cancelled' | ||
| | 'payment_error' | ||
| | 'rejected' | ||
| const statusMap: { [key in PartnerStatuses]: Status } = { |
src/partners/0xgasless.ts
Outdated
| datelog(`Snoozing ${60 * retry}s`) | ||
| await snooze(60000 * retry) | ||
| } else { | ||
| // We can't safely save our progress since we go from newest to oldest. |
There was a problem hiding this comment.
technically not true since you use a date range this is earlier and work your way up to present. One small fix that would be needed (and also in the paybis plugin) is to only set latestIsoDate if you have fully finished
There was a problem hiding this comment.
See my untested fixup commit
src/partners/0xgasless.ts
Outdated
|
|
||
| const ssTx: StandardTx = { | ||
| status, | ||
| orderId: trade.zid, |
There was a problem hiding this comment.
This MUST match the orderId used by the 0x exchange plugin. I don't think it does.
src/partners/0xgasless.ts
Outdated
|
|
||
| const { | ||
| isoDate: tradeIsoDate, | ||
| timestamp: tradeTimestamp |
There was a problem hiding this comment.
why rename isoDate and timestamp. There's no conflict and it would match the StandardTx type for easy assignment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
none