Implement JSON-RPC WebSocket server #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samholmes
force-pushed
the
sam/websockets
branch
2 times, most recently
from
34b9770 to
cdeae1f
Compare
swansontec
requested changes
Aug 13, 2024
The process ID is included in the pino log data already
samholmes
force-pushed
the
sam/websockets
branch
from
cdeae1f to
6217796
Compare
swansontec
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note to reviewer
A good amount of this PR is infra for supporting serverlet routes for HTTP endpoints. Some changes to serverlet's utilities could be brought upstream to accomplish the needs of this integration (lowering the line count for this PR).
In addition to using serverlets for the HTTP protocol, this PR demonstrates the use of serverlets for the WS and JSON-RPC protocols. It turns out with a small change to serverlet's types, it is a nice fit as an framework for building out the necessary middleware for WS and JSON-RPC support. Perhaps this could be accepted as a stand-alone serverlet middleware package for other upcoming WebSocket projects.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
none