Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(color): adjust font size of text in Choice box to fit #5458

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

philmoz
Copy link
Collaborator

@philmoz philmoz commented Aug 18, 2024

Changes:

  • adjust padding on Choice button to fit more text
  • where Choice button is fixed width, use smaller font if text does not fit.

@philmoz philmoz added this to the 2.11 milestone Aug 19, 2024
@philmoz philmoz added color Related generally to color LCD radios UX-UI Related to user experience (UX) or user interface (UI) behaviour labels Aug 19, 2024
@pfeerick pfeerick changed the title feat(color): adjust font size of text in Choice box to fit. feat(color): adjust font size of text in Choice box to fit Aug 20, 2024
@pfeerick
Copy link
Member

LGTM on TX16S, EL18. Can you think of any instances offhand where this would show smaller text now for EN firmware?

@pfeerick pfeerick merged commit add61da into main Aug 20, 2024
47 checks passed
@pfeerick pfeerick deleted the philmoz/choice-fit-txt branch August 20, 2024 00:21
@philmoz
Copy link
Collaborator Author

philmoz commented Aug 20, 2024

LGTM on TX16S, EL18. Can you think of any instances offhand where this would show smaller text now for EN firmware?

Input or Mix -> Weight -> set Source to GV and give GV a name.

@pfeerick
Copy link
Member

Ok, reduction in size just wasn't as noticeable as I expected... as this is what I had already tried.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
color Related generally to color LCD radios UX-UI Related to user experience (UX) or user interface (UI) behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants