Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cpn): ADC switch type hardware definition #5846

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

elecpower
Copy link
Collaborator

@elecpower elecpower commented Jan 27, 2025

Summary of changes:

  • handle ADC switch type
  • ADC switch TOGGLE set to non-toggle 3 position switch as toggle could be 2 or 3 positions

Note: hardware setup, assignable switches, simulator and yaml read/write will use 3 position non-toggle logic.

PL18 in main

Screenshot from 2025-01-27 21-18-43

Screenshot from 2025-01-27 21-22-30

@elecpower elecpower added bug 🪲 Something isn't working companion Related to the companion software labels Jan 27, 2025
@elecpower elecpower added this to the 2.11 milestone Jan 27, 2025
@pfeerick pfeerick merged commit 3e42ed3 into main Jan 28, 2025
3 checks passed
@pfeerick pfeerick deleted the elecpower/cpn-add-hwdefs-adc branch January 28, 2025 00:10
@pfeerick
Copy link
Member

Thanks for smacking this into submission so quickly :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working companion Related to the companion software
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants