Skip to content

Latest commit

 

History

History
2259 lines (1624 loc) · 93.8 KB

DeveloperGuide.adoc

File metadata and controls

2259 lines (1624 loc) · 93.8 KB

ProgressChecker - Developer Guide

By: Team T09-B3      Since: Feb 2018      Licence: MIT

1. Introduction

ProgressChecker is for students who prefer to use a desktop app to keep track of their learning progressthroughout the certain module. (Current version is available for CS2103/T)

For the current version, you can add your teammates details into ProgressChecker. You can also create a new task list through google task. By default, app will display all the Learning Outcomes taken from the CS2103/T module website for this week in the task list. Students can use this task list to track their weekly homework and the progress of the project.

More importantly, ProgressChecker is optimized for students who prefer to work with a Command Line Interface (CLI) while still having the benefits of a Graphical User Interface (GUI). If you can type fast, ProgressChecker can get your learning outcome tasks done faster than traditional GUI apps.

Now you are ready to jump to the Setting up to get started. Enjoy!

2. Icons Meaning

You will be seeing these icons throughout the guide. Each icon display specific information.

💡
This lightbulb icon means tips that you can try when using ProgressChecker.
ℹ️
This info icon means notes that you should pay attention to when using ProgressChecker.

3. Setting up

There are some things you will need to set up before getting started in contributing to ProgressChecker. Below lists the important key elements you will have to configure.

3.1. Prerequisites

  1. JDK 1.8.0_60 or later

    ℹ️
    Having any Java 8 version is not enough.
    This app will not work with earlier versions of Java 8.
  2. IntelliJ IDE

    ℹ️
    IntelliJ by default has Gradle and JavaFx plugins installed.
    Do not disable them. If you have disabled them, go to File > Settings > Plugins to re-enable them.

3.2. Setting up the project in your computer

  1. Fork this repo, and clone the fork to your computer

  2. Open IntelliJ (if you are not in the welcome screen, click File > Close Project to close the existing project dialog first)

  3. Set up the correct JDK version for Gradle

    1. Click Configure > Project Defaults > Project Structure setup2
      step 3.i

    2. Click New…​ and find the directory of the JDK

  4. Click Import Project

  5. Locate the build.gradle file and select it. Click OK
    setup3
    step 5

  6. Click Open as Project

  7. Click OK to accept the default settings

  8. Open a console and run the command gradlew processResources (Mac/Linux: ./gradlew processResources). It should finish with the BUILD SUCCESSFUL message.
    This will generate all resources required by the application and tests. setup5
    step 8

3.3. Verifying the setup

  1. Run the gradlew.bat run and try a few commands

  2. Run the tests to ensure they all pass.

3.4. Configurations to do before writing code

3.4.1. Configuring the coding style

This project follows oss-generic coding standards. IntelliJ’s default style is mostly compliant with ours but it uses a different import order from ours. To rectify,

  1. Go to File > Settings…​ (Windows/Linux), or IntelliJ IDEA > Preferences…​ (macOS)

  2. Select Editor > Code Style > Java

  3. Click on the Imports tab to set the order

    • For Class count to use import with '*' and Names count to use static import with '*': Set to 999 to prevent IntelliJ from contracting the import statements

    • For Import Layout: The order is import static all other imports, import java.*, import javax.*, import org.*, import com.*, import all other imports. Add a <blank line> between each import

Optionally, you can follow the UsingCheckstyle.adoc document to configure Intellij to check style-compliance as you write code.

3.4.2. Updating documentation to match your fork

After forking the repo, links in the documentation will still point to the CS2103JAN2018-T09-B3/main repo. If you plan to develop this as a separate product (i.e. instead of contributing to the CS2103JAN2018-T09-B3/main) , you should replace the URL in the variable repoURL in DeveloperGuide.adoc and UserGuide.adoc with the URL of your fork.

3.4.3. Setting up CI

Set up Travis to perform Continuous Integration (CI) for your fork. See UsingTravis.adoc to learn how to set it up.

After setting up Travis, you can optionally set up coverage reporting for your team fork (see UsingCoveralls.adoc).

ℹ️
Coverage reporting could be useful for a team repository that hosts the final version but it is not that useful for your personal fork.

Optionally, you can set up AppVeyor as a second CI (see UsingAppVeyor.adoc).

ℹ️
Having both Travis and AppVeyor ensures your App works on both Unix-based platforms and Windows-based platforms (Travis is Unix-based and AppVeyor is Windows-based)

3.4.4. Getting started with coding

Now you are ready to start coding! You can:

  1. Get some sense of the overall design by reading Design Architecture.

  2. Take a look at Appendix A, Suggested Programming Tasks to Get Started.

4. Design

ProgressChecker consists of multiple components that work together via an event-driven structure. This section will break down the various components in details to help you jump straight into understanding the architecture in depth.

4.1. Architecture

The Architecture Diagram given below explains the high-level design of the App. Given below is a quick overview of each component.

Architecture
Figure 1. Architecture Diagram


💡
The .pptx files used to create diagrams in this document can be found in the diagrams folder. To update a diagram, modify the diagram in the pptx file, select the objects of the diagram, and choose Save as picture.


Main has only one class called MainApp. It is responsible for:

  • Initializing the components in the correct sequence, and connects them up with each other at app launch.

  • Shutting down the components and invokes cleanup method where necessary.

Commons represents a collection of classes used by multiple other components. Two of those classes play important roles at the architecture level.

  • EventsCenter : This class (written using Google’s Event Bus library) is used by components to communicate with other components using events (i.e. a form of Event Driven design)

  • LogsCenter : Used by many classes to write log messages to the App’s log file.

The rest of the App consists of four components.

  • UI: The UI of the App.

  • Logic: The command executor.

  • Model: Holds the data of the App in-memory.

  • Storage: Reads data from, and writes data to, the hard disk.

Each of the four components

  • Defines its API in an interface with the same name as the Component.

  • Exposes its functionality using a {Component Name}Manager class.

For example, the Logic component (see the class diagram given below) defines it’s API in the Logic.java interface and exposes its functionality using the LogicManager.java class.

LogicClassDiagram
Figure 2. Class Diagram of the Logic Component


Events-Driven nature of the design

The Sequence Diagram below shows how the components interact for the scenario where the user issues the command delete 1.

SDforDeletePerson
Figure 3. Component interactions for delete 1 command (part 1)


ℹ️
Note how the Model simply raises a ProgressCheckerChangedEvent when the Address Book data are changed, instead of asking the Storage to save the updates to the hard disk.


The diagram below shows how the EventsCenter reacts to that event, which eventually results in the updates being saved to the hard disk and the status bar of the UI being updated to reflect the 'Last Updated' time.

SDforDeletePersonEventHandling
Figure 4. Component interactions for delete 1 command (part 2)


ℹ️
Note how the event is propagated through the EventsCenter to the Storage and UI without Model having to be coupled to either of them. This is an example of how this Event Driven approach helps us reduce direct coupling between components.


The sections below give more details of each component.

4.2. UI component

UiClassDiagram
Figure 5. Structure of the UI Component


API : Ui.java

The UI consists of a MainWindow that is made up of parts e.g.CommandBox, ResultDisplay, PersonListPanel, StatusBarFooter, BrowserPanel etc. All these, including the MainWindow, inherit from the abstract UiPart class.

The UI component uses JavaFx UI framework. The layout of these UI parts are defined in matching .fxml files that are in the src/main/resources/view folder. For example, the layout of the MainWindow is specified in MainWindow.fxml

The UI component,

  • Executes user commands using the Logic component.

  • Binds itself to some data in the Model so that the UI can auto-update when data in the Model change.

  • Responds to events raised from various parts of the App and updates the UI accordingly.

4.3. Logic component

LogicClassDiagram
Figure 6. Structure of the Logic Component


LogicCommandClassDiagram
Figure 7. Structure of Commands in the Logic Component. This diagram shows finer details concerning XYZCommand and Command in Figure 6, “Structure of the Logic Component”


API : Logic.java

  1. Logic uses the ProgressCheckerParser class to parse the user command.

  2. This results in a Command object which is executed by the LogicManager.

  3. The command execution can affect the Model (e.g. adding a teammate) and/or raise events.

  4. The result of the command execution is encapsulated as a CommandResult object which is passed back to the Ui.

Given below is the Sequence Diagram for interactions within the Logic component for the execute("delete 1") API call.

DeletePersonSdForLogic
Figure 8. Interactions Inside the Logic Component for the delete 1 Command

4.4. Model component

ModelClassDiagram
Figure 9. Structure of the Model Component

API : Model.java

The Model,

  • stores a UserPref object that represents the user’s preferences.

  • stores the Address Book data.

  • exposes an unmodifiable ObservableList<Person> that can be 'observed' e.g. the UI can be bound to this list so that the UI automatically updates when the data in the list change.

  • does not depend on any of the other three components.

4.5. Storage component

StorageClassDiagram
Figure 10. Structure of the Storage Component


API : Storage.java

The Storage component,

  • can save UserPref objects in json format and read it back.

  • can save the Address Book data in xml format and read it back.

4.6. Common classes

Classes used by multiple components are in the seedu.progresschecker.commons package.

5. Implementation

This section describes some noteworthy details on how certain features are implemented.

5.1. Undo/Redo feature

5.1.1. Current Implementation

The undo/redo mechanism is facilitated by an UndoRedoStack, which resides inside LogicManager. It supports undoing and redoing of commands that modifies the state of the ProgressChecker (e.g. add, edit). Such commands will inherit from UndoableCommand.

UndoRedoStack only deals with UndoableCommands. Commands that cannot be undone will inherit from Command instead. The following diagram shows the inheritance diagram for commands:

LogicCommandClassDiagram
Figure 11. Structure of Commands in the Logic Component


As you can see from the diagram, UndoableCommand adds an extra layer between the abstract Command class and concrete commands that can be undone, such as the DeleteCommand. Note that extra tasks need to be done when executing a command in an undoable way, such as saving the state of the ProgressChecker before execution. UndoableCommand contains the high-level algorithm for those extra tasks while the child classes implements the details of how to execute the specific command. Note that this technique of putting the high-level algorithm in the parent class and lower-level steps of the algorithm in child classes is also known as the template pattern.

Commands that are not undoable are implemented this way:

public class ListCommand extends Command {
    @Override
    public CommandResult execute() {
        // ... list logic ...
    }
}

With the extra layer, the commands that are undoable are implemented this way:

public abstract class UndoableCommand extends Command {
    @Override
    public CommandResult execute() {
        // ... undo logic ...

        executeUndoableCommand();
    }
}

public class DeleteCommand extends UndoableCommand {
    @Override
    public CommandResult executeUndoableCommand() {
        // ... delete logic ...
    }
}

Suppose that the user has just launched the application. The UndoRedoStack will be empty at the beginning.

The user executes a new UndoableCommand, delete 5, to delete the 5th teammate in the ProgressChecker. The current state of the ProgressChecker is saved before the delete 5 command executes. The delete 5 command will then be pushed onto the undoStack (the current state is saved together with the command).

UndoRedoStartingStackDiagram
Figure 12. Undo/Redo Stack at Starting Point


As the user continues to use the program, more commands are added into the undoStack. For example, the user may execute add n/David …​ to add a new teammate.

UndoRedoNewCommand1StackDiagram
Figure 13. Undo/Redo Stack with New Command add


ℹ️
If a command fails its execution, it will not be pushed to the UndoRedoStack at all.

The user now decides that adding the teammate was a mistake, and decides to undo that action using undo.

We will pop the most recent command out of the undoStack and push it back to the redoStack. We will restore the ProgressChecker to the state before the add command executed.

UndoRedoExecuteUndoStackDiagram
Figure 14. Undo/Redo Stack with Command undo


ℹ️
If the undoStack is empty, then there are no other commands left to be undone, and an Exception will be thrown when popping the undoStack.

The following sequence diagram shows how the undo operation works:

UndoRedoSequenceDiagram
Figure 15. Sequence Diagram of Undo/Redo


The redo does the exact opposite (pops from redoStack, push to undoStack, and restores the ProgressChecker to the state after the command is executed).

ℹ️
If the redoStack is empty, then there are no other commands left to be redone, and an Exception will be thrown when popping the redoStack.

The user now decides to execute a new command, clear. As before, clear will be pushed into the undoStack. This time the redoStack is no longer empty. It will be purged as it no longer make sense to redo the add n/David command (this is the behavior that most modern desktop applications follow).

UndoRedoNewCommand2StackDiagram
Figure 16. Undo/Redo Stack with New Command clear


Commands that are not undoable are not added into the undoStack. For example, list, which inherits from Command rather than UndoableCommand, will not be added after execution:

UndoRedoNewCommand3StackDiagram
Figure 17. Undo/Redo Stack with Command list


The following activity diagram summarize what happens inside the UndoRedoStack when a user executes a new command:

UndoRedoActivityDiagram
Figure 18. Activity Diagram of Undo/Redo

5.1.2. Design Considerations

Aspect: Implementation of UndoableCommand
Alternative Pros Cons

Add a new abstract method executeUndoableCommand()
(current choice)

We will not lose any undone/redone functionality as it is now part of the default behaviour. Classes that deal with Command do not have to know that executeUndoableCommand() exist.

Hard for new developers to understand the template pattern.

Override execute()

Does not involve the template pattern, easier for new developers to understand.

Cons: Classes that inherit from UndoableCommand must remember to call super.execute(), or lose the ability to undo/redo.


Aspect: How undo & redo executes

Alternative

Pros

Cons

Save the entire ProgressChecker
(current choice)

Easy to implement.

May have performance issues in terms of memory usage.

Individual command knows how to undo/redo by itself

Will use less memory (e.g. for delete, just save the teammate being deleted).

We must ensure that the implementation of each individual command are correct.


Aspect: Type of commands that can be undone/redone

Alternative

Pros

Cons

Only include commands that modifies the ProgressChecker (add, clear, edit)
(current choice)

We only revert changes that are hard to change back (the view can easily be re-modified as no data are * lost).

User might think that undo also applies when the list is modified (undoing filtering for example), * only to realize that it does not do that, after executing undo.

Include all commands

Might be more intuitive for the user.

User have no way of skipping such commands if he or she just want to reset the state of the ProgressChecker and not the view.

ℹ️
Additional Info: See our discussion here.


Aspect: Data structure to support the undo/redo commands
Alternative Pros Cons

Use separate stack for undo and redo
(current choice)

Easy to understand for new Computer Science student undergraduates to understand, who are likely to be * the new incoming developers of our project.

Logic is duplicated twice. For example, when a new command is executed, we must remember to update * both HistoryManager and UndoRedoStack.

Use HistoryManager for undo/redo

We do not need to maintain a separate stack, and just reuse what is already in the codebase.

Cons: Requires dealing with commands that have already been undone: We must remember to skip these commands. Violates Single Responsibility Principle and Separation of Concerns as HistoryManager now needs to do two * different things.

5.2. Upload feature

5.2.1. Planned Implementation

The Upload command will allow users to upload their preferred image to replace the default profile photo.

The valid photo to be upload will be copies from local path inside resources folder under /images/contact. The name of the file will be renamed according to the time that the photo is uploaded.

Upload can be undoable. The diagram below shows how the EventsCenter reacts to uploadPhoto event.

SDforUploadPhoto
Figure 19. Component Interactions for uploadPhoto Command


UploadCommand is implemented this way:

public class UploadCommand extends UndoableCommand {
    @Override
    public CommandResult executeUndoableCommand() throws CommandException {
        requireNonNull(personToUpdate);
        try {
            model.addPhoto(photoPath);
            model.uploadPhoto(personToUpdate, savePath);
            return new CommandResult(MESSAGE_SUCCESS);
        } catch (PersonNotFoundException pnfe) {
            throw new AssertionError("The target person cannot be missing");
        } catch (DuplicatePhotoException e) {
            throw new CommandException(MESSAGE_IMAGE_DUPLICATE);
        } catch (DuplicatePersonException e) {
            throw new CommandException(MESSAGE_IMAGE_DUPLICATE);
        }
    }
}
ℹ️
Users are allowed to reload the image if they want to update the profile photo.

Here is the code to copy the photo from local path inside resources folder.

public String copyLocalPhoto(String localPath) throws IOException {
    File localFile = new File(localPath);
    String newPath = createSavePath(localPath);
    if (!localFile.exists()) {
        throw new FileNotFoundException(MESSAGE_LOCAL_PATH_CONSTRAINTS);
    }
    createSavedPhoto(newPath);
    try {
        copyFile(localPath, newPath);
    } catch (IOException e) {
        throw new IOException(MESSAGE_COPY_FAIL);
    }
    return newPath;
}
ℹ️
If the local path is invalid or the image cannot be found, the upload will not be successful. The extension of the file can only be 'jpg', 'jpeg' or 'png'. User will be asked to write the correct path to image again.

5.2.2. Design Considerations

Aspect: Implementation of UploadCommand
Alternative Pros Cons

User will provide the path of image
(current choice)

The path can be used directly to find the image and display it in the app.

Image may be a local file. When other users open the app, they cannot see the update.

User will upload image into our github folder manually

Everyone can see the update of profile photo.

Quite trobulesome to upload photo manually first.

5.3. Dynamic Search Implementation

5.3.1. Current Implementation

The find command shows the searched contact currently. However, the user does not need to type the complete name press enter, the whole search is dynamic. As soon as the user types the command find dynamic search state is toggled. After typing find command, whichever character is entered by the user, the results which contain the typed keywords appear.

To implement the dynamic search, we used the following method - as soon as the user enters any character in the command box, the text is retrieved from the command box and checked if it is the find command. If it is the find command, dynamic search is started. After the find command is detected in the command box, every key that is pressed is parsed and sent to the find command parser. After that the basic functionality of find is used and the results are displayed.

The code snippet for the implementation is:

if ((commandTextField.getText().trim().equalsIgnoreCase(CORRECT_COMMAND_WORD)
                        || isCorrectCommandWord)) {
                    isCorrectCommandWord = !commandTextField.getText().trim().isEmpty();
                    CommandResult commandResult;
                    if (keyEvent.getCode() != KeyCode.BACK_SPACE && keyEvent.getCode() != KeyCode.DELETE) {
                        commandResult = logic.execute(commandTextField.getText() + keyEvent.getText());
                    } else {
                        commandResult = logic.execute(commandTextField.getText().substring(0,
                                commandTextField.getText().length() - 1));
                    }
                    // process result of the command
                    logger.info("Result: " + commandResult.feedbackToUser);
                    raise(new NewResultAvailableEvent(commandResult.feedbackToUser));
                }
    }
ℹ️
The entered key is not instantly updated in the command box thats why after the commandTextField.getText() is executed we need to append\delete a character for the code to the result to process the right input - the one that the user can see on their screens.

5.3.2. Design consideration

Aspect: User Interface (UI)
Alternative Pros Cons

Show the search results without actually highlighting the keywords
(current choice)

Allows more readability of the of the results as they contain multiple fields and not just user name.

User needs to manually search for the keywords entered by him in the search results.

Show the search results WITH highlighting the keywords in the searched name

It will make it easier for the user to view the user to identify the searched keyword in the displayed results.

Adding highlights to the results might make the displayed results a bit too cluttered specially with the presence of tags which are colored as well.

5.4. Toggling between tab views

5.4.1. Current Implementation

This command toggles the view between the different type of tabs in the software.

TabView
Figure 20. Reference of the tab view in the software


It inherits Command and executes on an Event Driven design between the Logic and UI component.

Suppose that the user is on the Task tab and wants to toggle to the Exercise tab. The user executes a new Command, view exercise, to switch to the Exercise tab. The Sequence Diagram below shows how the components interact with each other.

SDforViewExercise
Figure 21. Logic and UI component interaction for view exercise command (part 1)


ℹ️
Note how the Logic simply raises a TabLoadChangedEvent when the view command gets executed. The TabLoadChangedEvent is implemented as follows:
public class TabLoadChangedEvent extends BaseEvent {
    public final String type;

    public TabLoadChangedEvent(String type) {
        this.type = type;
    }

    @Override
    public String toString() {
        return this.getClass().getSimpleName();
    }

    public String getTabName() {
        return type;
    }
}

The diagram below shows how the EventCenter reacts to that event, which eventually results in the UI updating to which tab view is to be in selection.

SDforViewExerciseEventHandling
Figure 22. Logic and UI component interaction for view exercise command (part 2)


ℹ️
The UI scene’s elements are automatically populated in MainWindow.java due to using JavaFX FXML Controller. That is, a reference to a particular UI element will be available as long as it has its fx:id specified in MainWindow.fxml.

The code snippet below shows how the UI component executes the toggling of tab view upon receiving the event change.

@Subscribe
private void handleTabLoadChangedEvent(TabLoadChangedEvent event) {
    logger.info(LogsCenter.getEventHandlingLogMessage(event));
    SingleSelectionModel<Tab> selectionModel = tabPlaceholder.getSelectionModel();
    switch (event.getTabName()) {
    case "profile":
        selectionModel.select(profilePlaceholder);
        break;
    case "task":
        selectionModel.select(taskPlaceholder);
        break;
    case "exercise":
        selectionModel.select(exercisePlaceholder);
        break;
    case "issues":
        selectionModel.select(issuePlaceholder);
        break;
    default:
        selectionModel.select(selectionModel.getSelectedItem());
    }
}

5.5. View, answer, and save for an exercise

5.5.1. Current Implementation

This command allows user to answer an exercise based on the question index shown in the software.

QuestionIndexIndication
Figure 23. Reference of the question index in the software


It inherits UndoableCommand and executes through all four components in the code base.

Suppose that the user wants to answer an exercise with index 11.1.1. The user executes a new Command, ans 11.1.1 a, to answer the exercise. The Sequence Diagram below shows how the components interact with each other.

SDforAnswerExercise
Figure 24. Component interactions for ans 11.1.1 a command (part 1)


ℹ️
Note how the Model simply raises a ProgressCheckerChangedEvent when the ProgressChecker data has been changed, instead of asking the Storage to save the updates to the hard disk.


The diagram below shows how the EventsCenter reacts to that event, which eventually results in the updates being saved to the hard disk.

SDforAnswerExerciseEventHandling
Figure 25. Component interactions for ans 11.1.1 a command (part 2)


Before the Logic component executes the Undoable Command which calls the Model, it prepares the exercise that needs to be updated by going through the internal list of exercises stored in model. The code that searches for the exercise is as follows:

for (Exercise e : exerciseList) {
    if (e.getQuestionIndex().toString().equals(questionIndex.toString())) {
        exerciseToEdit = exerciseList.get(exerciseList.indexOf(e));
        editedExercise = createEditedExercise(exerciseToEdit, studentAnswer);
        isFound = true;
        break;
    }
}

The internal list, exerciseList, is implemented as an observable list of filtered exercises in Model. Upon calling the ProgressCheckerChangedEvent, Storage will run saveProgressChecker. Subsequently, to load the data on the next software start up requires parsing of xml data into Model. The following code snippet shows how Storage does so:

public Exercise toModelType() throws IllegalValueException {
    if (this.questionIndex == null) {
        throw new IllegalValueException(
                String.format(MISSING_FIELD_MESSAGE_FORMAT,
                QuestionIndex.class.getSimpleName()));
    }
    if (!QuestionIndex.isValidIndex(this.questionIndex)) {
        throw new IllegalValueException(QuestionIndex.MESSAGE_INDEX_CONSTRAINTS);
    }
    final QuestionIndex questionIndex = new QuestionIndex(this.questionIndex);

    if (this.questionType == null) {
        throw new IllegalValueException(
                String.format(MISSING_FIELD_MESSAGE_FORMAT,
                QuestionType.class.getSimpleName()));
    }
    if (!QuestionType.isValidType(this.questionType)) {
        throw new IllegalValueException(QuestionType.MESSAGE_TYPE_CONSTRAINTS);
    }
    final QuestionType questionType = new QuestionType(this.questionType);

    ...

    return new Exercise(questionIndex, questionType, question, studentAnswer, modelAnswer);
}

Additionally, since it is an observable list, the UI element harboring this list will update any changes made to this list accordingly. In viewing of exercises by week, the list is filtered with predicate as follows:

model.updateFilteredExerciseList(exercise -> exercise.getQuestionIndex().getWeekNumber()
                == editedExercise.getQuestionIndex().getWeekNumber());

5.5.2. Design Considerations

Aspect: Viewing of exercises by week
Alternative Pros Cons

Adapt from View Command by adding additional WEEK_NUMBER parameter to type exercise
(current choice)

Not required to create a new command and hence more cohesive with the existing commands as well as one less command for users to learn

ViewCommandParser requires additional parser check to separate between the View Command that can take in WEEK_NUMBER to one that doesn’t which might violate SLAP principle

Create a new command to list exercises by week

Standalone from existing commands and hence easier to be built upon or removed without consequences

Creates an extra unnecessary complication for users having to learn a new command when the existing View Command essentially does something similar

Aspect: Loading of exercises data on fresh start
Alternative Pros Cons

Include all exercises data in SampleDataUtil and read from there
(current choice)

No additional processing required, is easy to modify whenever default data needs to be changed

Is directly affected by the Clear Command that is meant for the list of Persons which user may not expect it to be for

Read from stored text file, parse accordingly, and load into software on fresh start

Standalone data and will not be affected by changes made to list of Persons

Incurs extra overhead when parsing the text file into Java objects

5.6. Tasks

5.6.1. Current Implementation

The default LOs for all weeks would be stored in a local file, which will be loaded as input to create a task list on the user’s Google Account with Google Tasks API.

There are several commands related to tasks, including newtasklist to add and upload the default task list, viewtasklist FILTER_KEYWORD to view the default task list with filtering, completetask INDEX/resettask INDEX to mark a task as completed/not completed, and goto INDEX to open the URL of a task. As an example, the High Level Sequence Diagram and Sequence Diagram below shows how the components interact for the scenario where the user issues the command viewtasklist 5.

HighLevelSDforViewTaskListCommand
Figure 26. Component Interactions for viewtasklist 5 Command (High Level)


SDforViewTaskListCommand
Figure 27. Component Interactions for viewtasklist 5 Command


We apply Google Tasks API to help us save user tasks data online. This offers back up data which allow our users to recover their tasks and status of each task even after uninstalling the application. The task list will be ready to display once the user reinstall and open the application. To use Google Tasks API, we fist need to register this project on google developer console and retrieve a client credential file (client_id.json) to authorize our project. Then, add corresponding dependencies to build.gradle, the library files will be downloaded automatically upon project rebuild.

Here is the code snippet to add dependencies:

compile (
    ['com.google.api-client:google-api-client:1.23.0'],
    ['com.google.apis:google-api-services-tasks:v1-rev49-1.23.0'],
    ['com.google.oauth-client:google-oauth-client-jetty:1.23.0'],
)
ℹ️
Simply downloading JAR files without editing gradle is not suggested. JARs are not in git thus our co-developers will rely on the dependencies to retrieve the libraries. Also, set gradleVersion to 4.6 if it is an older version, otherwise runtime compilation of Google API library will affect Junit tests.

We write a program to authorize our project (by loading the aforementioned client credential file), trigger user loggin and build service. Note that when users are using ProgressChecker, only the first tasks command requires them to log in and authorize ProgressChecker to access their Google Tasks data with their google accounts.

Google Tasks API helps us save time building massive data structures (ie. Tasks, TaskLists, Lists of TaskLists, as well as many methods and exceptions). However, we do have a few classes (eg. TaskUtil, TaskListUtil) in the modeling part that further add customized methods which are useful for current commands and even future commands. In this way, we avoid repetition of code snippet and having big chunks of import statements in numerous commands.

Here is a code snippet that can find a task list by its title (while the native method only finds task by its id which is not memorable or even known by our users):

/**
 * Finds the task list with title {@code String listTitle} from the user's task lists
 *
 * @param listTitle title of the task list we look for
 * @return the task list instance
 */
public static TaskList searchTaskList(String listTitle) throws CommandException {
    TaskList taskList = null;
    ConnectTasksApi connection = new ConnectTasksApi();
    try {
        connection.authorize();
    } catch (Exception e) {
        throw new CommandException(AUTHORIZE_FAILURE);
    }
    Tasks service = connection.getTasksService();
    try {
    TaskLists taskLists = service.tasklists().list().execute();
        taskList = taskLists.getItems().stream()
                .filter(t -> t.getTitle().equals(listTitle))
                .findFirst()
                .orElse(null);
    } catch (IOException ioe) {
        throw new CommandException(LOAD_FAILURE);
    }

    return taskList;
}

5.6.2. Design Considerations

Aspect: Implementation of tasks commands
  • All these commands extend Command but not extend UndoableCommand. AddDefaultTasksCommand, CompleteTaskCommand and ResetTaskCommand make external changes that update task list in users' Google account, which is out of the scope of undo command. ViewTaskListCommand and GoToTaskUrlCommand do not make changes to the data, thus no applicable to undo command.

Aspect: How AddDefaultTasksCommand is executed
  • This command will load the tasks from local storage and add a task list filled with these tasks to the user’s Google account.

Alternative

Pros

Cons

Find the user’s Google task list with ID "@default" (this is the default task list in Google Task and not removable). Create a new task list and transfer the tasks from @default to the new one. Then change the title of @default to "CS2103 LOs", and add the tasks loaded from local storage
(current choice)

The other tasks commands will only need to refer to the ID "@default" to find the task list, which is faster and more accurate than searching with title ( as list ID is unique while list title can duplicate and the native API method only supports finding list with ID).

It requires more steps, thus slower (but fortunately this command should only be executed ONCE in the lifetime of this application).

Create a new list with title "CS2103 LOs", then load and push all tasks from local storage

Will be a bit faster.

The other task commands will be slower since they will be finding the list with title. The commands may also encounter error if there are task list with the same name in the user’s Google account.


Aspect: How ViewTaskListCommand is executed
  • This command will load the tasks from task list @default from the user’s Google account and apply user-specified filter before displaying

Alternative

Pros

Cons

Find the user’s @default task list and load the whole list. Then apply user-specified filter to select applicable tasks to form a new list. The new list will be ready to be displayed
(current choice)

Easy to implement, well modularized.

More repetitions of list traversal.

Find the user’s @default task list and load the whole list. Then apply user-specified filter to select applicable tasks while processing the methods to display it

Easy to implement.

Might lead to complicated methods to display list (eg. multi-level abstraction).


Aspect: How CompleteTaskCommand and ResetTaskCommand is executed
  • This command will set the task with user-input index number as completed/ not completed.

Alternative

Pros

Cons

Find the user’s @default task list and retrieve the task with user-input index number. Check if it needs update, and update it if necessary.
(current choice)

Easy to implement.


Aspect: How GoToTaskUrl is executed
  • This command will open the URL of the task with the user-input index number.

Alternative

Pros

Cons

Find the user’s @default task list and retrieved the task based on the input index. Get the URL in the task object and open it in the browser panel
(current choice)

Easy to implement.

No need for implementation, the user can click the hyperlink while viewing the task list

No need for implementation.

Not command line based.


Aspect: What UI structure to show the task list

Alternative

Pros

Cons

Use a browser panel.
(current choice)

Can show task list and external websites linked to tasks in the same panel.

Exercise list, issue list and person list are all shown in a list panel. The handling of browser panel and list panel is different, which leads to inconsistency.

Use a list panel to display tasks, and a browser panel to display external webpages

Guarantees consistency between task list, exercise list, issue list and person list.

Takes more space.


Aspect: What can we improve / what command can we add in v2.0
  • Send reminder email to the user when a deadline is near

  • Back/Forward the browser panel

  • View teammates' task list and progress (Google Tasks does not support it. Thus, a possible implementation is to sync data with the help of Google Drive API. After every transaction with Google Tasks, we retrieve the task list and save in Google Drive. Students in the same team will use a shared folder on Google Drive, thus can access each other’s task list data. ProgressChecker will retrieve teammate task list data from the shared folder in Google Drive).


5.7. Github Login

5.7.1. Current Implemetation

The GitDetails represents an object that is used to authenticate github. It contains Username, Passcode, and Repository object which represent the github account’s username, password and repository respectively.

ℹ️
All fields are compulsory for github authentication. .UML diagram for github details image::gitdetails.png[width="800"]

GitDetails object is not stored locally as it can violate user’s data and privacy. To manage the github account following command classes can be used:

  • GitLoginCommand

  • GitLogoutCommand

GitLoginCommand needs to be used for tracking any issue activity on the ProgressChecker application. After the GitDetails object is created, its member’s are used to create a Github object from the Github API library which is used to authenticate github.

Implementation of github login and issue tracking is done with the help of GitHub API for Java (org.kohsuke.github). ==== Logging into github

User can log into github after using the GitLoginCommand. After executing the command, a GitDetails object is created

Given below is a sequence diagram for authenticating github.

gitlogin1
Figure 28. UML Diagram for Github details

The following code snippet shows how GitLoginCommand#execute() will update the model by creating Github object which will be used to authenticate github.

public class GitLoginCommand extends Command {
@Override
    public CommandResult execute() throws CommandException {

        try {
            model.loginGithub(toAuthenticate);
            return new CommandResult(MESSAGE_SUCCESS);
        } catch (IOException e) {
            throw new CommandException(MESSAGE_FAILURE);
        } catch (CommandException ce) {
            throw new CommandException(ce.getMessage());
        }
    }
}

5.7.2. Design considerations

Aspect: Using password for authentication

Alternative

Pros

Cons

Used github password for authentication
(current choice)

User easily remebers his password, thus logging in is easy.

Password cannot be stored offline to protect users data and privacy.

Using OAuth token for authentication

OAuth token can be stored offline which can provide one-time login functionality, as we can restrict the token’s usage for only ProgressChecker application.

Manually generating a token by the user is a tedious task and github tokens expire regularly which can be a pain for the user.

5.8. Github Issue Tracker

5.8.1. Current Implementation

The Issue object represents an issue that is to be created on github. It contains Title, Assignees, Milestone, Body, and Labels which are the different attributes of an issue on github.

ℹ️
Only the Title field is compulsory for Issue as this the only limitation set by github.
issueobject
Figure 29. UML diagram for github Issue

Issue objects are not stored in memory after an issue is created on github. The issues are not stored in a local file to protect users confidential data and privacy.

Issue tracking is done by several command classes, namely:

  • CreateIssueCommand

  • CloseIssueCommand

  • EditIssueCommand

  • ReopenIssueCommand

  • ListIssueCommand

All the above commands will only work after you have logged into github. Use 'gitLogin' command to login.

5.8.2. Creating an issue

An issue is created on github using the CreateIssueCommand. After executing the command, an Issue object is created which is then converted to a GHIssue object present in the Github Library. GHIssue is then posted online using the Github API library.

Given below is the sequence diagram for creating an issue on github.

finalcreateIssue
Figure 30. High level sequence diagram for creating a new issue on github

The following code snippet shows how CreateIssueCommand#execute() will update the model of the application by creating an issue toCreate on github and later updating the GitIssueList. Note: This an issue will not be created if you haven’t logged into github.

public class CloseIssueCommandTest {
...
@Override
    public CommandResult execute() throws CommandException {

        try {
            model.createIssueOnGitHub(toCreate);
            return new CommandResult(MESSAGE_SUCCESS);
        } catch (IOException | CommandException e) {
            throw new CommandException(MESSAGE_FAILURE);
        }
    }
    ...
}

The issue created will be shown on the Issues tab in the application.

5.8.3. Closing an issue

An issue can be closed on github using the CloseIssueCommand. After executing the command, a GHIssue object of the specified index is retrieved from the Github database. The state of the GHIssue is checked and it is marked as closed if it is open.

Given below is the sequence diagram for closing an issue.

closeissue
Figure 31. High Level Sequence Diagram for closing an issue on github

The following code snippet shows how CloseIssueCommand#execute() will update the model of application by closing an issue updating the GitIssueList. Note: The entered index number should be a valid issue index, and the user should be logged into github before using the command.

public class CloseIssueCommand extends Command {
@Override
    public CommandResult execute() throws CommandException {
        try {
            model.closeIssueOnGithub(targetIndex);
        } catch (IOException ie) {
            throw new CommandException(MESSAGE_FAILURE);
        } catch (CommandException ce) {
            throw new CommandException(MESSAGE_AUTHENTICATION_FAILURE);
        }

        return new CommandResult(String.format(MESSAGE_SUCCESS, targetIndex.getOneBased()));
    }
}

The issue created will be removed from the Issues tab in the application, as by default only open issues are displayed.

5.8.4. Design considerations

Aspect: Storing issues on a local file

Alternative

Pros

Cons

Not storing the issues offline
(current choice)

Users data and privacy is protected, as issues on github might contain very confidential data regarding the product’s information.

The user cannot view the exisitng issues offline and he can not use the software to work offline and then push everything online once the internet connection is available.

Implementing data encryption so that the issues can be stored offline

User will be able work offline on issues and post changes when internet connection is availabe.

In order to do offline authentication and decrypt the issue data, the application will have to store the user credentials offline which might violate Github’s API policy.

5.9. Logging

We are using java.util.logging package for logging. The LogsCenter class is used to manage the logging levels and logging destinations.

  • The logging level can be controlled using the logLevel setting in the configuration file (See Section 5.10, “Configuration”)

  • The Logger for a class can be obtained using LogsCenter.getLogger(Class) which will log messages according to the specified logging level

  • Currently log messages are output through: Console and to a .log file.

Logging Levels

  • SEVERE : Critical problem detected which may possibly cause the termination of the application

  • WARNING : Can continue, but with caution

  • INFO : Information showing the noteworthy actions by the App

  • FINE : Details that is not usually noteworthy but may be useful in debugging e.g. print the actual list instead of just its size

5.10. Configuration

Certain properties of the application can be controlled (e.g App name, logging level) through the configuration file (default: config.json).

6. Documentation

We use asciidoc for writing documentation. This section talks about how you can modify and publish the existing documentations.

ℹ️
We chose asciidoc over Markdown because asciidoc, although a bit more complex than Markdown, provides more flexibility in formatting.

6.1. Editing Documentation

See UsingGradle.adoc to learn how to render .adoc files locally to preview the end result of your edits. Alternatively, you can download the AsciiDoc plugin for IntelliJ, which allows you to preview the changes you have made to your .adoc files in real-time.

6.2. Publishing Documentation

See UsingTravis.adoc to learn how to deploy GitHub Pages using Travis.

6.3. Converting Documentation to PDF format

We use Google Chrome for converting documentation to PDF format, as Chrome’s PDF engine preserves hyperlinks used in webpages.

Here are the steps to convert the project documentation files to PDF format.

  1. Follow the instructions in UsingGradle.adoc to convert the AsciiDoc files in the docs/ directory to HTML format.

  2. Go to your generated HTML files in the build/docs folder, right click on them and select Open withGoogle Chrome.

  3. Within Chrome, click on the Print option in Chrome’s menu.

  4. Set the destination to Save as PDF, then click Save to save a copy of the file in PDF format. For best results, use the settings indicated in the screenshot below.

chrome save as pdf
Figure 32. Saving documentation as PDF files in Chrome

7. Testing

ProgressChecker uses JUnit tests to check for its correctness. This section covers the type of tests and how to run them.

7.1. Types of tests

We have two types of tests:

  1. GUI Tests - These are tests involving the GUI. They include,

    1. System Tests that test the entire App by simulating user actions on the GUI. These are in the systemtests package.

    2. Unit tests that test the individual components. These are in seedu.progresschecker.ui package.

  2. Non-GUI Tests - These are tests not involving the GUI. They include,

    1. Unit tests targeting the lowest level methods/classes.
      e.g. seedu.progresschecker.commons.StringUtilTest

    2. Integration tests that are checking the integration of multiple code units (those code units are assumed to be working).
      e.g. seedu.progresschecker.storage.StorageManagerTest

    3. Hybrids of unit and integration tests. These test are checking multiple code units as well as how the are connected together.
      e.g. seedu.progresschecker.logic.LogicManagerTest

7.2. Troubleshooting Testing

Problem: HelpWindowTest fails with a NullPointerException.

  • Reason: One of its dependencies, UserGuide.html in src/main/resources/docs is missing.

  • Solution: Execute Gradle task processResources.

8. Dev Ops

8.1. Build Automation

See UsingGradle.adoc to learn how to use Gradle for build automation.

8.2. Continuous Integration

We use Travis CI and AppVeyor to perform Continuous Integration on our projects. See UsingTravis.adoc and UsingAppVeyor.adoc for more details.

8.3. Coverage Reporting

We use Coveralls to track the code coverage of our projects. See UsingCoveralls.adoc for more details.

8.4. Documentation Previews

When a pull request has changes to asciidoc files, you can use Netlify to see a preview of how the HTML version of those asciidoc files will look like when the pull request is merged. See UsingNetlify.adoc for more details.

8.5. Making a Release

Here are the steps to create a new release.

  1. Update the version number in MainApp.java.

  2. Generate a JAR file using Gradle.

  3. Tag the repo with the version number. e.g. v0.1

  4. Create a new release using GitHub and upload the JAR file you created.

8.6. Managing Dependencies

A project often depends on third-party libraries. For example, Address Book depends on the Jackson library for XML parsing. Managing these dependencies can be automated using Gradle. For example, Gradle can download the dependencies automatically, which is better than these alternatives.
a. Include those libraries in the repo (this bloats the repo size)
b. Require developers to download those libraries manually (this creates extra work for developers)

Appendix A: Suggested Programming Tasks to Get Started

It might be your first time working with a large code base. If so, here is a suggested path for new programmers to kick start your first functionality:

  1. First, add small local-impact (i.e. the impact of the change does not go beyond the component) enhancements to one component at a time. Some suggestions are given in Section A.1, “Improving each component”.

  2. Next, add a feature that touches multiple components to learn how to implement an end-to-end feature across all components. Section A.2, “Creating a new command: remark explains how to go about adding such a feature.

A.1. Improving each component

Each individual exercise in this section is component-based (i.e. you would not need to modify the other components to get it to work).

Logic component

Scenario: You are in charge of logic. During dog-fooding, your team realize that it is troublesome for the user to type the whole command in order to execute a command. Your team devise some strategies to help cut down the amount of typing necessary, and one of the suggestions was to implement aliases for the command words. Your job is to implement such aliases.

💡
Do take a look at Section 4.3, “Logic component” before attempting to modify the Logic component.
  1. Add a shorthand equivalent alias for each of the individual commands. For example, besides typing clear, the user can also type c to remove teammates in the list.

    • Hints

    • Solution

      • Modify the switch statement in ProgressCheckerParser#parseCommand(String) such that both the proper command word and alias can be used to execute the same intended command.

      • Add new tests for each of the aliases that you have added.

      • Update the user guide to document the new aliases.

      • See this PR for the full solution.

Model component

Scenario: You are in charge of model. One day, the logic-in-charge approaches you for help. He wants to implement a command such that the user is able to remove a particular tag from everyone in the ProgressChecker, but the model API does not support such a functionality at the moment. Your job is to implement an API method, so that your teammate can use your API to implement his command.

💡
Do take a look at Section 4.4, “Model component” before attempting to modify the Model component.
  1. Add a removeTag(Tag) method. The specified tag will be removed from everyone in the ProgressChecker.

    • Hints

      • The Model and the ProgressChecker API need to be updated.

      • Think about how you can use SLAP to design the method. Where should we place the main logic of deleting tags?

      • Find out which of the existing API methods in ProgressChecker and Person classes can be used to implement the tag removal logic. ProgressChecker allows you to update a teammate, and Person allows you to update the tags.

    • Solution

      • Implement a removeTag(Tag) method in ProgressChecker. Loop through each teammates, and remove the tag from each teammate.

      • Add a new API method deleteTag(Tag) in ModelManager. Your ModelManager should call ProgressChecker#removeTag(Tag).

      • Add new tests for each of the new public methods that you have added.

      • See this PR for the full solution.

        • The current codebase has a flaw in tags management. Tags no longer in use by anyone may still exist on the ProgressChecker. This may cause some tests to fail. See issue #753 for more information about this flaw.

        • The solution PR has a temporary fix for the flaw mentioned above in its first commit.

Ui component

Scenario: You are in charge of ui. During a beta testing session, your team is observing how the users use your ProgressChecker application. You realize that one of the users occasionally tries to delete non-existent tags from a contact, because the tags all look the same visually, and the user got confused. Another user made a typing mistake in his command, but did not realize he had done so because the error message wasn’t prominent enough. A third user keeps scrolling down the list, because he keeps forgetting the index of the last teammate in the list. Your job is to implement improvements to the UI to solve all these problems.

💡
Do take a look at Section 4.2, “UI component” before attempting to modify the UI component.
  1. Use different colors for different tags inside teammate cards. For example, friends tags can be all in brown, and colleagues tags can be all in yellow.

    Before

    getting started ui tag before

    After

    getting started ui tag after
    • Hints

      • The tag labels are created inside the PersonCard constructor (new Label(tag.tagName)). JavaFX’s Label class allows you to modify the style of each Label, such as changing its color.

      • Use the .css attribute -fx-background-color to add a color.

      • You may wish to modify DarkTheme.css to include some pre-defined colors using css, especially if you have experience with web-based css.

    • Solution

      • You can modify the existing test methods for PersonCard 's to include testing the tag’s color as well.

      • See this PR for the full solution.

        • The PR uses the hash code of the tag names to generate a color. This is deliberately designed to ensure consistent colors each time the application runs. You may wish to expand on this design to include additional features, such as allowing users to set their own tag colors, and directly saving the colors to storage, so that tags retain their colors even if the hash code algorithm changes.

  2. Modify NewResultAvailableEvent such that ResultDisplay can show a different style on error (currently it shows the same regardless of errors).

    Before

    getting started ui result before

    After

    getting started ui result after
  3. Modify the StatusBarFooter to show the total number of people in the ProgressChecker.

    Before

    getting started ui status before

    After

    getting started ui status after
    • Hints

      • StatusBarFooter.fxml will need a new StatusBar. Be sure to set the GridPane.columnIndex properly for each StatusBar to avoid misalignment!

      • StatusBarFooter needs to initialize the status bar on application start, and to update it accordingly whenever the ProgressChecker is updated.

    • Solution

Storage component

Scenario: You are in charge of storage. For your next project milestone, your team plans to implement a new feature of saving the ProgressChecker to the cloud. However, the current implementation of the application constantly saves the ProgressChecker after the execution of each command, which is not ideal if the user is working on limited internet connection. Your team decided that the application should instead save the changes to a temporary local backup file first, and only upload to the cloud after the user closes the application. Your job is to implement a backup API for the ProgressChecker storage.

💡
Do take a look at Section 4.5, “Storage component” before attempting to modify the Storage component.
  1. Add a new method backupProgressChecker(ReadOnlyProgressChecker), so that the ProgressChecker can be saved in a fixed temporary location.

A.2. Creating a new command: remark

By creating this command, you will get a chance to learn how to implement a feature end-to-end, touching all major components of the app.

Scenario: You are a software maintainer for progresschecker, as the former developer team has moved on to new projects. The current users of your application have a list of new feature requests that they hope the software will eventually have. The most popular request is to allow adding additional comments/notes about a particular contact, by providing a flexible remark field for each contact, rather than relying on tags alone. After designing the specification for the remark command, you are convinced that this feature is worth implementing. Your job is to implement the remark command.

A.2.1. Description

Edits the remark for a teammate specified in the INDEX.
Format: remark INDEX r/[REMARK]

Examples:

  • remark 1 r/Likes to drink coffee.
    Edits the remark for the first teammate to Likes to drink coffee.

  • remark 1 r/
    Removes the remark for the first teammate.

A.2.2. Step-by-step Instructions

[Step 1] Logic: Teach the app to accept 'remark' which does nothing

Let’s start by teaching the application how to parse a remark command. We will add the logic of remark later.

Main:

  1. Add a RemarkCommand that extends UndoableCommand. Upon execution, it should just throw an Exception.

  2. Modify ProgressCheckerParser to accept a RemarkCommand.

Tests:

  1. Add RemarkCommandTest that tests that executeUndoableCommand() throws an Exception.

  2. Add new test method to ProgressCheckerParserTest, which tests that typing "remark" returns an instance of RemarkCommand.

[Step 2] Logic: Teach the app to accept 'remark' arguments

Let’s teach the application to parse arguments that our remark command will accept. E.g. 1 r/Likes to drink coffee.

Main:

  1. Modify RemarkCommand to take in an Index and String and print those two parameters as the error message.

  2. Add RemarkCommandParser that knows how to parse two arguments, one index and one with prefix 'r/'.

  3. Modify ProgressCheckerParser to use the newly implemented RemarkCommandParser.

Tests:

  1. Modify RemarkCommandTest to test the RemarkCommand#equals() method.

  2. Add RemarkCommandParserTest that tests different boundary values for RemarkCommandParser.

  3. Modify ProgressCheckerParserTest to test that the correct command is generated according to the user input.

[Step 3] Ui: Add a placeholder for remark in PersonCard

Let’s add a placeholder on all our PersonCard s to display a remark for each person later.

Main:

  1. Add a Label with any random text inside PersonListCard.fxml.

  2. Add FXML annotation in PersonCard to tie the variable to the actual label.

Tests:

  1. Modify PersonCardHandle so that future tests can read the contents of the remark label.

[Step 4] Model: Add Remark class

We have to properly encapsulate the remark in our Person class. Instead of just using a String, let’s follow the conventional class structure that the codebase already uses by adding a Remark class.

Main:

  1. Add Remark to model component (you can copy from Address, remove the regex and change the names accordingly).

  2. Modify RemarkCommand to now take in a Remark instead of a String.

Tests:

  1. Add test for Remark, to test the Remark#equals() method.

[Step 5] Model: Modify Person to support a Remark field

Now we have the Remark class, we need to actually use it inside Person.

Main:

  1. Add getRemark() in Person.

  2. You may assume that the user will not be able to use the add and edit commands to modify the remarks field (i.e. the person will be created without a remark).

  3. Modify SampleDataUtil to add remarks for the sample data (delete your progressChecker.xml so that the application will load the sample data when you launch it.)

[Step 6] Storage: Add Remark field to XmlAdaptedPerson class

We now have Remark s for Person s, but they will be gone when we exit the application. Let’s modify XmlAdaptedPerson to include a Remark field so that it will be saved.

Main:

  1. Add a new Xml field for Remark.

Tests:

  1. Fix invalidAndValidPersonProgressChecker.xml, typicalPersonsProgressChecker.xml, validProgressChecker.xml etc., such that the XML tests will not fail due to a missing <remark> element.

[Step 6b] Test: Add withRemark() for PersonBuilder

Since Person can now have a Remark, we should add a helper method to PersonBuilder, so that users are able to create remarks when building a Person.

Tests:

  1. Add a new method withRemark() for PersonBuilder. This method will create a new Remark for the person that it is currently building.

  2. Try and use the method on any sample us in TypicalPersons.

[Step 7] Ui: Connect Remark field to PersonCard

Our remark label in PersonCard is still a placeholder. Let’s bring it to life by binding it with the actual remark field.

Main:

  1. Modify PersonCard's constructor to bind the Remark field to the Person 's remark.

Tests:

  1. Modify GuiTestAssert#assertCardDisplaysPerson(…​) so that it will compare the now-functioning remark label.

[Step 8] Logic: Implement RemarkCommand#execute() logic

We now have everything set up…​ but we still can’t modify the remarks. Let’s finish it up by adding in actual logic for our remark command.

Main:

  1. Replace the logic in RemarkCommand#execute() (that currently just throws an Exception), with the actual logic to modify the remarks of a teammate.

Tests:

  1. Update RemarkCommandTest to test that the execute() logic works.

A.2.3. Full Solution

See this PR for the step-by-step solution.

Appendix B: Product Scope

This section covers what ProgressChecker is meant to be and what it can do for the users.

Target user profile:

  • is taking CS2103T in NUS

  • has a need to manage a up to 4 contacts

  • wants to have a centralized hub for managing his/her learning and software development

  • wants to keep track on his/her learning outcomes and progress

  • wants to save and refer to their answers for the weekly CS2103/T exercises

  • wants to manage GitHub issues efficiently

  • prefers desktop apps over other platforms

  • prefers typing over mouse input

  • is reasonably comfortable using CLI apps

Value proposition:

  • keep track of your teammates' details

  • keep track of your own progress on a week by week basis

  • never miss any learning outcomes due to missing them out in nested collapsible list

  • keep track of completed and incomplete (compulsory) learning outcomes

  • view and save your answers for the exercises (as proof of completion and for future revision)

  • manage issues from GitHub straight from the software along with other tracking

Appendix C: Feature Contribution

The names of the contributors and their contributions to the project are listed here in brief.

C.1. Koh Yee Ru

  1. (Major) View, answer and save responses for weekly CS2103/T exercises

  2. (Minor) View command that toggles the tab view TabView

C.2. Kang Anmin

  1. (Major) Task management: Add LOs to google tasks (the users google account, load tasks and sign completion.

  2. (Minor) Progress Bar: to give a graphic view of tasks completeness

  3. (Minor) Change/Add more fields of information for teammates in the contact list, in order to fit the specific context of this software. It also lays a foundation for other operations.

C.3. Lai Liwen

  1. (Major) Revamp the UI: rearrange the different sections and panels to best suit audience’s needs

  2. (Major) Upload profile photo: students will be able to upload a photo to their profile

  3. (Minor) HighLight the key word: the key word will be highlighted in command find

C.4. Aditya Agarwal

  1. (Major) Create a github issue tracker which will be used to track issues on github using the ProgressChecker application.

  2. (Minor) Implement dynamic search

Appendix D: User Stories

This section lists the actions that both new and long-time users can and may want to perform with ProgressChecker.

Priorities: High (must have) - * * *, Medium (nice to have) - * *, Low (unlikely to have) - *

Priority As a …​ I want to …​ So that I can…​

* * *

new user

see usage instructions

refer to instructions when I forget how to use the App

* * *

new user

fill in my details such as name, email, 8 digits phone number

provide necessary information for platform maintenance

* * *

new user

fill in optional fields such as faculty, year of study, etc.

help my teammates know me better

* * *

user

update information of certain field(s)

keep my information up-to-date

* * *

user

add a teammate’s details

help myself to track my current teammates' progress

* * *

user

delete a teammate’s details

remove an entry of a teammate’s details that I’m no longer grouped with

* * *

new user

upload a photo for myself or my teammates

help me to recognize my teammates

* * *

user

view my to-do learning outcomes

know all the weekly deliverables and not miss them out

* * *

user

mark a to-do learning outcome as completed

focus on the tasks I have not done

* * *

user

answer and save my responses for the weekly exercises

show to tutor as proof of my learning outcome and revise before exams

* * *

user

know if my answer for an exercise is correct

learn from any mistakes I made

* * *

user

list issues (tasks) on GitHub

easily inform my teammates of my upcoming plans even before I send any pull requests to the team’s repository

* * *

user

assign issues (tasks) to my teammates

track who is doing what

* * *

user

see the issues (tasks) listed on GitHub

easily know the upcoming plans of my teammates even before they send any pull requests to the team’s repository

* * *

user

close issues (tasks) on GitHub

easily inform my teammates of a completed task if no particular pull requests closes it

* *

user

see the timeline showing the learning progress of me and my teammates

make sure everyone is on track

* *

new user

load a photo of myself or my teammates from GitHub

help me to recognize my teammates

* *

user

see the list of completed/incomplete learning outcomes of my teammates

help to remind my teammate of the task or know which task to offer help with if they are having difficulties

* *

user

search information in our module website based on keywords

navigate and reference the information I need quickly

* *

user

hide private contact details by default

minimize chance of someone else seeing them by accident

* *

user with many teammates in the ProgressChecker

sort teammates by name

locate a teammate easily

Appendix E: Use Cases

This section list the sequence of events for a feature. It includes possible scenarios in which a feature is not interacted with as intended which you can defense against.

(For all use cases below, the System is the ProgressChecker and the Actor is the user, unless specified otherwise)

Use case: View (toggle) a different tab

MSS

  1. User requests to view a specific tab type

  2. ProgressChecker toggles tab view to show the requested tab

    Use case ends.

Extensions

  • 1a. The given tab type is invalid.

    • 1a1. ProgressChecker shows an error message. Use case ends.

  • 2a. There is no content to be shown.

    Use case ends.

Use case: Add teammate

MSS

  1. User requests to add a specific teammate in the list

  2. ProgressChecker add the teammate

    Use case ends.

Extensions

  • 1a. The teammate has already been existing in the list.

    • 1a1. ProgressChecker shows an error message.

      Use case resumes at step 1.

  • 1a. The given information is invalid.

    • 1a1. ProgressChecker shows an error message.

      Use case resumes at step 1.

Use case: Add the default task list

MSS

  1. User requests to add the task list

  2. If this is the first google-task-relevant command used by the user in this session, user is requested to log in his/her google account

  3. ProgressChecker loads and parses local file, adds the task list to user’s google account

    Use case ends.

Extensions

  • 2a. No Internet Access.

    Use case ends.

  • 2b. Invalid client credential file.

    Use case ends.

  • 2c. Invalid user log in information.

    Use case ends.

  • 3a. The file is not found.

    Use case ends.

  • 3b. The file is corrupted.

    Use case ends.

Use case: View Task List

MSS

  1. User requests to view the task list with a filter argument

  2. If this is the first google-task-relevant command used by the user in this session, user is requested to log in his/her google account

  3. ProgressChecker makes request to the user’s google account to load the task list.

    Use case ends.

Extensions

  • 1a. The argument is invalid.

    Use case ends.

  • 2a. No Internet Access.

    Use case ends.

  • 2b. Invalid client credential file.

    Use case ends.

  • 2c. Invalid user log in information.

    Use case ends.

Use case: Complete a task

MSS

  1. User requests to mark a task as completed

  2. If this is the first google-task-relevant command used by the user in this session, user is requested to log in his/her google account

  3. ProgressChecker marks the task as completed

    Use case ends.

Extensions

  • 1a. The index is invalid.

    Use case ends.

  • 2a. No Internet Access.

    Use case ends.

  • 2b. Invalid client credential file.

    Use case ends.

  • 2c. Invalid user log in information.

    Use case ends.

  • 3a. The index is valid but out of bound.

    Use case ends.

Use case: Reset a task

MSS

  1. User requests to reset a task as not completed

  2. If this is the first google-task-relevant command used by the user in this session, user is requested to log in his/her google account

  3. ProgressChecker resets the task as not completed

    Use case ends.

Extensions

  • 1a. The index is invalid.

    Use case ends.

  • 2a. No Internet Access.

    Use case ends.

  • 2b. Invalid client credential file.

    Use case ends.

  • 2c. Invalid user log in information.

    Use case ends.

  • 3a. The index is valid but out of bound.

    Use case ends.

Use case: Open URL of a task

MSS

  1. User requests to open URL of a task

  2. If this is the first google-task-relevant command used by the user in this session, user is requested to log in his/her google account

  3. ProgressChecker opens the URL and show in browser panel

    Use case ends.

Extensions

  • 1a. The index is invalid.

    Use case ends.

  • 2a. No Internet Access.

    Use case ends.

  • 2b. Invalid client credential file.

    Use case ends.

  • 2c. Invalid user log in information.

    Use case ends.

  • 3a. The index is valid but out of bound.

    Use case ends.

Use case: Answer a question and save

MSS

  1. User requests to view the exercise tab of week X

  2. ProgressChecker toggles to exercise tab and list week X’s exercises

  3. User requests to key in and save an answer to a question

  4. ProgressChecker takes in input and saves

    Use case ends.

Extensions

  • 1a. The given tab type is invalid.

    • 1a1. ProgressChecker shows an error message. Use case ends.

  • 1b. Specified week does not exist.

    • 1b1. ProgressChecker shows an error message.

      Use case ends.

  • 2a. There are no exercises to be shown.

    Use case ends.

  • 3a. User did not provide a question index.

    • 3a1. ProgressChecker shows an error message.

      Use case ends.

  • 3b. User did not provide an answer.

    • 3b1. ProgressChecker shows an error message.

      Use case ends.

  • 3c. The given question index does not exists.

    • 3c1. ProgressChecker shows an error message.

      Use case ends.

Use case: Assign an issue to a teammate

{ to be added }

Use case: Autocomplete a command

MSS

  1. User types an incomplete command

  2. User presses tab key to complete the command

  3. ProgessChecker returns the completed command with dummy fields if there exists a specific format

    Use case ends.

Extensions

  • 1a. Specified command does not exist.

    • 1a1. ProgressChecker doesn’t do anything and waits for the right key/command to be entered.

    • 1a2. It waits for the right letter to be pressed or the correct command to be entered.

      Use case resumes at step 1.

Use case: Delete teammate

MSS

  1. User requests to list teammates

  2. ProgressChecker shows a list of teammates

  3. User requests to delete a specific teammate in the list

  4. ProgressChecker deletes the teammate

    Use case ends.

Extensions

  • 2a. The list is empty.

    Use case ends.

  • 3a. The given index is invalid.

    • 3a1. ProgressChecker shows an error message.

      Use case resumes at step 2.

Use case: Close an issue

{ to be added }

Use case: Find teammate

MSS

  1. User types find

  2. ProgressChecker automatically shows the list dynamically without the user needing to press enter key

  3. User need not need to type the whole name, substrings will generate results

  4. ProgressChecker displays the necessary results

    Use case ends.

Extensions

  • 2a. The contact list is empty.

    Use case resumes at step 2.

  • 3a. The given substring doesn’t exist in any name

    • 3a1. ProgressChecker shows an error message.

      Use case resumes at step 2.

Use case: List an issue

{ to be added }

Use case: Mark a learning outcome as completed

MSS

  1. User requests to list tasks(LOs)

  2. ProgressChecker shows a list of tasks(LOs)

  3. User provides an index to requests to mark the corresponding LO in the list as completed

  4. If this is the first google-task-relevant command used by the user in this session, user is requested to log in his/her google account

  5. ProgressChecker executes command to mark the LO as completed in google tasks under the user’s google account

    Use case ends.

Extensions

  • 2a. The list is empty.

    Use case ends.

  • 2b. The list has not been created yet (invalid list name).

    Use case ends.

  • 3a. The given index is invalid.

    • 3a1. ProgressChecker shows an error message.

      Use case resumes at step 2.

Use case: Search for information

{ to be added }

Use case: Upload a photo for the profile

MSS

  1. User requests to view their profile

  2. ProgressChecker shows the profile of the user

  3. User requests to upload a new photo to the profile

  4. ProgressChecker adds a new photo to the profile of user

  5. Profile displays the new photo

    Use case ends.

Extensions

  • 1a. Picture intented to add cannot be found.

    • 1a1. ProgressChecker shows an error message.

      Use case resumes at step 2.

Appendix F: Non Functional Requirements

This sections list the criteria needed for the system and software.

  1. Should work on any mainstream OS as long as it has Java 1.8.0_60 or higher installed.

  2. A user with above average typing speed for regular English text (i.e. not code, not system admin commands) should be able to accomplish most of the tasks faster using commands than using the mouse.

  3. The data cannot be retrieved from outside.

  4. The product may need 3-5 minutes to build up for the first time.

  5. User need to authenticate with their Google Tasks credentials.

Appendix G: Glossary

Build Automation

Build automation is the process of automating the creation of a software build and the associated processes including: compiling computer source code into binary code, packaging binary code, and running automated tests.

Gradle

Gradle is an open-source build automation system.

GUI

Graphical User Interface.

[[Learning-Outcomes (LO)]] Learning Outcomes

Exercises that need to be done through GitHub for module CS2103/T.

Mainstream OS

Windows, Linux, Unix, MAC-OS(OS-X).

Private contact detail

A contact detail that is not meant to be shared with others.

Sequence Diagram

A sequence diagram shows object interactions shown in time sequence.

Appendix H: Instructions for Manual Testing

You may want to do manual testing to familiarise yourself with the software. Given below are instructions to test the app manually.

ℹ️
These instructions only provide a starting point for testers to work on; testers are expected to do more exploratory testing.

H.1. Launch and Shutdown

  1. Initial launch

    1. Download the jar file and copy into an empty folder

    2. Double-click the jar file
      Expected: Shows the GUI with a set of sample contacts. The window size may not be optimum.

  2. Saving window preferences

    1. Resize the window to an optimum size. Move the window to a different location. Close the window.

    2. Re-launch the app by double-clicking the jar file.
      Expected: The most recent window size and location is retained.

H.2. Deleting a teammate

  1. Deleting a teammate while all teammates are listed

    1. Prerequisites: List all teammates using the list command. Multiple teammates in the list.

    2. Test case: delete 1
      Expected: First contact is deleted from the list. Details of the deleted contact shown in the status message. Timestamp in the status bar is updated.

    3. Test case: delete 0
      Expected: No teammate is deleted. Error details shown in the status message. Status bar remains the same.

    4. Other incorrect delete commands to try: delete, delete x (where x is larger than the list size) {give more}
      Expected: Similar to previous.

H.3. Log into Github

  1. Logging in to github when not not logged in

    1. Prerequisites: User shouldn’t have logged into github

    2. Test case: gitlogin gu/USERNAME pc/PASSCODE r/REPOSITORY
      Expected: You have successfully logged into github!

    3. Test case: gitlogin gu/WRONG_USERNAME pc/PASSCODE r/REPOSITORY
      Expected: Enter correct username and password.

    4. Other incorrect gitlogin commands to try: gitlogin,
      Expected: Invalid command format.

H.4. Create an issue on github

  1. Create issue on github after logging in

    1. Prerequisites: User should have logged into github with correct repository

    2. Test case: +issue ti/Test b/test body ms/v1.1 a/johndoe l/bug
      Expected: You have successfully created an issue on github!

    3. Test case: +issue ti/Test b/test body ms/INVALID_MILESTONE a/johndoe l/bug
      Expected: Enter correct milestone.

    4. Other incorrect +issue commands to try: +issue,
      Expected: Invalid command format.

H.5. Edit an issue on github

  1. Edit issue on github after logging in

    1. Prerequisites: User should have logged into github with correct repository

    2. Test case: editissue 123 ti/Test b/test body ms/v1.1 a/johndoe l/bug
      Expected: You have successfully editted an issue on github!

    3. Test case: editissue 99999 ti/Test b/test body ms/v1.1 a/johndoe l/bug
      Expected: Issue not edited. Enter correct index number.

    4. Other incorrect editissue commands to try: editissue,
      Expected: Invalid command format.

H.6. Close an issue on github

  1. Close an issue on github after logging in

    1. Prerequisites: User should have logged into github with correct repository

    2. Test case: -issue 37
      Expected: Issue #37 has successfully been closed!

    3. Test case: -issue 9999
      Expected: Issue not closed. Enter correct index number.

    4. Other incorrect close issue commands to try: -issue 3 text,
      Expected: Invalid command format.

H.7. Reopen an issue on github

  1. Reopen an issue on github after logging in

    1. Prerequisites: User should have logged into github with correct repository

    2. Test case: reopenissue 37
      Expected: Issue #37 has successfully been reopened!

    3. Test case: reopenissue 9999
      Expected: Issue not reopened. Enter correct index number.

    4. Other incorrect reopen issue commands to try: reopen 3 text,
      Expected: Invalid command format.

H.8. List issues on github

  1. List issues on github after logging in

    1. Prerequisites: User should have logged into github with correct repository

    2. Test case: listissues OPEN
      Expected: All open issues are listed!

    3. Test case: listissues ssxss
      Expected: Enter correct state value.

    4. Other incorrect list issues commands to try: listissues,
      Expected: Invalid command format.

H.9. Logout of Github

  1. Log out of github after logging in

    1. Prerequisites: User should have logged into github with correct repository

    2. Test case: gitlogout
      Expected: You have successfully logged out of github!

    3. Prerequisites: User should not have logged into github

    4. Test case: gitlogout
      Expected: Please log into github first to logout.

H.10. Saving data

  1. Dealing with missing/corrupted data files

    1. {explain how to simulate a missing/corrupted file and the expected behavior}

{ more test cases …​ }

H.11. Toggling a tab view

  1. Navigate to another tab view

    1. Test case: view exercise
      Expected: UI toggles the tab view to the Exercise tab. A list of exercises should be displayed.

    2. Test case: view exercise 5
      Expected: UI toggles the tab view to the Exercise tab. Week 5’s list of exercises should be displayed.

    3. Test case: view invalidtype
      Expected: No such tab found. Error details shown in the status message.

    4. Other incorrect view commands to try: view, view exercise x (where x is an input not within 2 to 11 (inclusive)
      Expected: Similar to previous.

H.12. Answering an exercise

  1. Answer an exercise and see the suggested answer

    1. Prerequisites: UI view is on the Exercise tab, showing week 11’s exercises.

    2. Test case: ans 11.1.1 a
      Expected: Question index 11.1.1 turns green. Answer a is reflected under "Your Answer" and suggested answer for question index 11.1.1 is revealed.

    3. Test case: view 11
      Expected: Given question index does not exist. Error details shown in the status message.

    4. Other incorrect answer commands to try: ans, ans 11.2
      Expected: Similar to previous.

Back to TOP