-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0007: Unified Embedding API #13
Draft
mkrueger12
wants to merge
3
commits into
main
Choose a base branch
from
007-Unified-Embeddings-API
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,72 @@ | ||
--- | ||
GEP: 0007 | ||
Title: Unified Embedding API | ||
Discussion: | ||
Implementation: | ||
--- | ||
|
||
# Unified Embedding API | ||
|
||
## Abstract | ||
|
||
This GEP discusses the unified embeddings api and its interactions with embedding model providers. | ||
|
||
## Motivation | ||
|
||
Many LLM applications have a semantic search feature within their architecture. To support these applications on Glide, a unified embedding api is necessary. | ||
This will allow applications to embed chat requests as part of a retrieval augmented generation (RAG) application flow. | ||
|
||
### Requirements | ||
|
||
- R1: Handles all provider specific logic | ||
- R2: Easily maintained | ||
- R3: API schemas must unify common request params (e.g. dimensions) | ||
- R4: API routes must unify common embedding endpoints/API | ||
|
||
## Design | ||
|
||
```yaml | ||
routes: | ||
chat: /v1/language/{pool-id}/chat/ | ||
transcribers: /v1/speech/transcribers/{pool-id}/ | ||
speech-synthesizer: /v1/speech/synthesizers/{pool-id}/ | ||
multi-modal: /v1/multi/{pool-id}/multimodal/ | ||
embedding: /v1/embeddings/{pool-id}/embed/ | ||
``` | ||
|
||
#### User Request Schema for Embedding Route | ||
|
||
```yaml | ||
{ | ||
"message": "Where was it played?", | ||
"dimensions": 1536 | ||
} | ||
``` | ||
|
||
#### Response Schema for Embedding Route | ||
```yaml | ||
{ | ||
"provider": "cohere", | ||
"model": "embed-multilingual-v3.0", | ||
"provider_response": { | ||
"embedding": [ | ||
0.0023064255, | ||
-0.009327292, | ||
.... | ||
-0.0028842222, | ||
], | ||
"token_count": { | ||
"prompt_tokens": 9, | ||
"total_tokens": 9 | ||
} | ||
} | ||
} | ||
``` | ||
|
||
## Alternatives Considered | ||
|
||
[TBU, what other solutions were considered and why they were rejected] | ||
|
||
## Future Work | ||
|
||
- Could we abstract away the entire RAG architecture? A single endpoint that takes a chat message -> embeds -> text semantic search -> LLM -> response | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This actually sounds like an idea for another service that would use Glide to talk to LLMs while providing RAG related addition to Glide's workflows. @mkrueger12 what do you think? What would be MVP for such a service? |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have recently changed
token_count
totoken_usage
. I feel like this is a bit more explicit.