Feat sync optim #12
Merged
Feat sync optim #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PierreGauthier
force-pushed
the
feat-sync-optim
branch
from
eb261c0 to
8ad6263
Compare
PierreGauthier
force-pushed
the
feat-sync-optim
branch
2 times, most recently
from
a7e3f92 to
998f215
Compare
PierreGauthier
force-pushed
the
feat-sync-optim
branch
from
998f215 to
3a710f7
Compare
|
@PierreGauthier that's a HUGE PR ;) I quickly navigated through the changed files. It looks ok to me. However, I could not yet test the changes regarding the sourceField sync performance. I would assume you've tested it in detail. If you want me to take a closer look, this will take some time as I am quite busy this and the next week. |
|
Hello @shochdoerfer , |
|
I'd trust your expertise. Merge it, and I'll check it when I have more time. If I find anything that could be improved, we can fix it afterward. Which Gally version do I need to use to test it? 1.2, I guess? |
PierreGauthier
force-pushed
the
feat-sync-optim
branch
from
077537a to
e02eab6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add liscence file, file header and implement new API to improve sourceField sync performances