Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature branch for SDK 2.1.0 #1393

Merged
merged 10 commits into from
Mar 26, 2024
Merged

Feature branch for SDK 2.1.0 #1393

merged 10 commits into from
Mar 26, 2024

Conversation

str4d
Copy link
Collaborator

@str4d str4d commented Mar 15, 2024 •
edited
Loading

  • Migrated to new accounts backend.
  • Seed relevance API.
  • Orchard enabled in backend and integrated into SDK.
  • Payments to TEX addresses supported.
  • Deprecated payment APIs either removed or returning an error with TEX addresses.

Author

  • Self-review: Did you review your own code in GitHub's web interface? Code often looks different when reviewing the diff in a browser, making it easier to spot potential bugs.
  • Automated tests: Did you add appropriate automated tests for any code changes?
  • Code coverage: Did you check the code coverage report for the automated tests? While we are not looking for perfect coverage, the tool can point out potential cases that have been missed.
  • Documentation: Did you update Docs as appropiate? (E.g README.md, etc.)
  • Run the app: Did you run the app and try the changes?
  • Did you provide Screenshots of what the App looks like before and after your changes as part of the description of this PR? (only applicable to UI Changes)
  • Rebase and squash: Did you pull in the latest changes from the main branch and squash your commits before assigning a reviewer? Having your code up to date and squashed will make it easier for others to review. Use best judgement when squashing commits, as some changes (such as refactoring) might be easier to review as a separate commit.

Reviewer

  • Checklist review: Did you go through the code with the Code Review Guidelines checklist?
  • Ad hoc review: Did you perform an ad hoc review? In addition to a first pass using the code review guidelines, do a second pass using your best judgement and experience which may identify additional questions or comments. Research shows that code review is most effective when done in multiple passes, where reviewers look for different things through each pass.
  • Automated tests: Did you review the automated tests?
  • Manual tests: Did you review the manual tests?You will find manual testing guidelines under our manual testing section
  • How is Code Coverage affected by this PR? We encourage you to compare coverage befor and after your changes and when possible, leave it in a better place. Learn More...
  • Documentation: Did you review Docs, README.md, LICENSE.md, and Architecture.md as appropriate?
  • Run the app: Did you run the app and try the changes? While the CI server runs the app to look for build failures or crashes, humans running the app are more likely to notice unexpected log messages, UI inconsistencies, or bad output data.

@str4d str4d added this to the iOS Zashi 1.0 milestone Mar 15, 2024
str4d and others added 3 commits March 15, 2024 14:37
@str4d
Remove UnspentTransactionOutputRepository
dd9942b 
This removes the last direct access to the `utxos` table; all access
now goes through the Rust FFI.

`SDKSynchronizer.latestUTXOs` is removed without replacement. It was
introduced during the initial addition of shielding support, but:

- It is no longer used anywhere inside the SDK (when added, it was
  used in a few other methods).
- It is not exposed in the `Synchronizer` protocol.
- It is AFAICT unused in Zashi iOS, Edge, and Unstoppable.
- It was functionally replaced by `refreshUTXOs`, which performs
  best-effort UTXO updates instead of failing on any error. (It also
  does not clear the `utxo`s table which makes it not equivalent.)
@str4d
Remove AccountRepository
86defc8 
This removes the last direct access to the `accounts` table; all access
now goes through the Rust FFI.
@str4d @LukasKorba
Migrate to latest in-progress revision of Rust crates
a5a0ef0 
- New backend method `ZcashRustBackend.isSeedRelevantToWallet`
- `ZcashRustBackend.scanBlocks` now takes a `fromState` argument.

Co-authored-by: Lukas Korba <[email protected]>
LukasKorba and others added 2 commits March 18, 2024 14:45
@LukasKorba
Public API isSeedRelevantToWallet
e1c600b 
- New public API `isSeedRelevantToWallet` has been implemented
- 2 swiftlint error have been resolved
- Mocks generated
@str4d
Merge pull request #1395 from LukasKorba/public-isSeedRelevantToWallet
730aee0 
Public API isSeedRelevantToWallet
@str4d str4d marked this pull request as ready for review March 25, 2024 22:30
@str4d
Copy link
Collaborator Author

str4d commented Mar 26, 2024

Force-pushed to replace FFI 0.7.0 with 0.7.1.

@LukasKorba LukasKorba merged commit b183b10 into main Mar 26, 2024
2 checks passed
@LukasKorba LukasKorba deleted the feature-2.1.0 branch March 26, 2024 17:00
daira
daira reviewed Mar 27, 2024
View reviewed changes
Sources/ZcashLightClientKit/Entity/TransactionEntity.swift
@@ -65,13 +65,16 @@ public enum ZcashTransaction {
public enum Pool {
case transaparent
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #1401.

daira
daira reviewed Mar 27, 2024
View reviewed changes
Copy link
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Post-hoc ACK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daira daira daira left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
iOS Zashi 1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@str4d @daira @LukasKorba