-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infer dispatch parameters from command signatures #138
base: master
Are you sure you want to change the base?
Conversation
@yCobanoglu what do you think about this change to the dispatcher? |
Co-authored-by: Sourcery AI <>
Sourcery Code Quality Report❌ Merging this PR will decrease code quality in the affected files by 0.50%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
Code Climate has analyzed commit 6fbf081 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (75% is the threshold). This pull request will bring the total coverage in the repository to 91.1% (0.0% change). View more on Code Climate. |
@yCobanoglu @khoidt @fsimonjetz Do you think it makes sense to change the dispatcher to work like this? If not, please close this PR. |
No description provided.