migration party fixes labels

[yCobanoglu]

No description provided.

[sourcery-ai]

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 5.83%.

Quality metrics	Before	After	Change
Complexity	0.90 ⭐	3.72 ⭐	2.82 👎
Method Length	58.23 ⭐	63.44 🙂	5.21 👎
Working memory	7.74 🙂	8.62 🙂	0.88 👎
Quality	76.88% ⭐	71.05% 🙂	-5.83% 👎

Other metrics	Before	After	Change
Lines	464	516	52

Changed files	Quality Before	Quality After	Quality Change
ebl/fragmentarium/application/annotations_service.py	75.12% ⭐	58.00% 🙂	-17.12% 👎
ebl/fragmentarium/infrastructure/mongo_annotations_repository.py	89.06% ⭐	89.06% ⭐	0.00%
ebl/tests/fragmentarium/test_annotations_service.py	60.82% 🙂	62.74% 🙂	1.92% 👍
ebl/transliteration/domain/text.py	85.77% ⭐	85.77% ⭐	0.00%

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
ebl/fragmentarium/application/annotations_service.py	AnnotationsService._migrate_and_fix_labels	23 😞	253 ⛔	16 ⛔	26.20% 😞	Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
ebl/tests/fragmentarium/test_annotations_service.py	test_update	0 ⭐	259 ⛔	16 ⛔	45.84% 😞	Try splitting into smaller methods. Extract out complex expressions
ebl/fragmentarium/application/annotations_service.py	AnnotationsService._cropped_image_from_annotations_helper	3 ⭐	103 🙂	15 😞	57.73% 🙂	Extract out complex expressions
ebl/tests/fragmentarium/test_annotations_service.py	test_cropped_images_from_sign	1 ⭐	134 😞	9 🙂	65.75% 🙂	Try splitting into smaller methods
ebl/tests/fragmentarium/test_annotations_service.py	test_generate_annotations	0 ⭐	98 🙂	11 😞	67.38% 🙂	Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

• ⭐ excellent
• 🙂 good
• 😞 poor
• ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

---

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

[lgtm-com]

This pull request introduces 6 alerts when merging ae07ee2 into 9e34a92 - view on LGTM.com

new alerts:

• 6 for Unused import

---

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.