Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dossier to fragment #587

Merged
merged 9 commits into from
Dec 11, 2024
Merged

Add dossier to fragment #587

merged 9 commits into from
Dec 11, 2024

Conversation

khoidt
Copy link
Contributor

@khoidt khoidt commented Dec 4, 2024

Summary by Sourcery

Integrate Rust into the CI workflow and Dockerfile to support Rust-based dependencies, ensuring compatibility by upgrading pip.

CI:

  • Add Rust installation step to the CI workflow to support Rust-based dependencies.

Deployment:

  • Update Dockerfile to include Rust installation and upgrade pip to ensure compatibility with Rust-based dependencies.

Copy link
Contributor

sourcery-ai bot commented Dec 4, 2024

Reviewer's Guide by Sourcery

This PR updates the CI/CD pipeline and Docker configuration to include Rust installation and pip upgrades. The changes ensure that Rust toolchain is available in both the GitHub Actions workflow and the Docker container environment.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added Rust installation to GitHub Actions workflow
  • Added step to install Rust using rustup
  • Added source command to load Rust environment variables
  • Added pip upgrade command before poetry installation
.github/workflows/main.yml
Updated Docker configuration to include Rust toolchain
  • Added pip upgrade command
  • Added Rust installation using rustup
  • Added Rust binary path to PATH environment variable
Dockerfile

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @khoidt - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please update the PR title and description to explain why Rust toolchain is being added to the build process. This seems like a significant change that should be documented.
  • Consider optimizing the Dockerfile by combining the pip upgrade and Rust installation into a single RUN command to reduce the number of layers in the final image.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

def fetch(self, id: str) -> DossierRecord: ...

@abstractmethod
def create(self, dossier_record: DossierRecord) -> str: ...

Check notice

Code scanning / CodeQL

Statement has no effect Note

This statement has no effect.

class DossiersRepository(ABC):
@abstractmethod
def query_by_ids(self, ids: Sequence[str]) -> Sequence[DossierRecord]: ...

Check notice

Code scanning / CodeQL

Statement has no effect Note

This statement has no effect.
Copy link

codeclimate bot commented Dec 11, 2024

Code Climate has analyzed commit c028dc0 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 98.9% (75% is the threshold).

This pull request will bring the total coverage in the repository to 91.5% (0.0% change).

View more on Code Climate.

@khoidt khoidt merged commit da7eca5 into master Dec 11, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant