Make end in DateRangeSchema not required

[ejimsan]

Summary by Sourcery

Enhancements:

• Make the 'end' field in DateRangeSchema optional by setting 'required' to False.

[sourcery-ai]

Reviewer's Guide by Sourcery

This PR modifies the date schemas to make them more flexible by making certain fields optional and allowing null values. The main changes involve updating field requirements in PartialDateSchema and DateRangeSchema.

Updated class diagram for Date Schemas

classDiagram
    class PartialDateSchema {
        - Integer year
        + Integer year allow_none=True
        Integer month allow_none=True
        Integer day allow_none=True
        String notes allow_none=True load_default=""
    }
    class DateRangeSchema {
        Nested PartialDateSchema start allow_none=True
        - Nested PartialDateSchema end allow_none=True
        + Nested PartialDateSchema end allow_none=True required=False
        String notes allow_none=True
    }

Loading

File-Level Changes

Change	Details	Files
Modified field requirements in date schemas to be more permissive	Changed year field to allow null values instead of being required Made the end field explicitly optional in date ranges while maintaining null value support	ebl/fragmentarium/application/date_schemas.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @ejimsan - I've reviewed your changes - here's some feedback:

Overall Comments:

• Making year optional in PartialDateSchema seems problematic - what's the use case for having a date without a year? This could lead to validation issues downstream. Please provide justification for this change.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[codeclimate]

Code Climate has analyzed commit c3d426b and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (75% is the threshold).

This pull request will bring the total coverage in the repository to 91.5% (0.0% change).

View more on Code Climate.