Skip to content

Commit

Permalink
Add Digitale Keilschrift Bibliothek to External Nos
Browse files Browse the repository at this point in the history
  • Loading branch information
ejimsan committed Jan 5, 2025
1 parent ce14307 commit 519fc75
Show file tree
Hide file tree
Showing 12 changed files with 134 additions and 85 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ exports[`Show manuscript line details 1`] = `
<span
class="reference-popover__citation"
>
Estrada & Wolfe, 2069: 7477711662481408-4847418310918144
Estrada & Wolfe, 2070: 7477711662481408-4847418310918144
[
l. 4'.2., 3'.
]
Expand Down
1 change: 1 addition & 0 deletions src/fragmentarium/domain/Fragment.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,7 @@ const config: Parameters<typeof Fragment['create']>[0] = {
hilprechtHeidelbergNumber: '123',
achemenetNumber: '123',
nabuccoNumber: '123',
digitaleKeilschriftBibliothekNumber: '123',
metropolitanNumber: '123',
louvreNumber: '123',
dublinTcdNumber: '123',
Expand Down
1 change: 1 addition & 0 deletions src/fragmentarium/domain/FragmentDtos.ts
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ export const ExternalNumberTypes = [
'hilprechtHeidelbergNumber',
'achemenetNumber',
'nabuccoNumber',
'digitaleKeilschriftBibliothekNumber',
'metropolitanNumber',
'louvreNumber',
'dublinTcdNumber',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,11 @@ exports[`Snapshot 1`] = `
</p>
<p>
Excavation no.:
waloub.1
am.1
</p>
<p>
Provenance:
Dilbat
Irisagrig
</p>
</small>
</div>
Expand Down Expand Up @@ -80,9 +80,9 @@ exports[`Snapshot 1`] = `
,
<time
datetime="2097-10-04"
datetime="2098-10-04"
>
4/10/2097
4/10/2098
</time>
)
</li>
Expand Down Expand Up @@ -129,7 +129,7 @@ exports[`Snapshot 1`] = `
<span
class="reference-popover__citation"
>
Fanti & Carr, 2037: 8970824935538688-3796097900216320
Fanti & Carr, 2038: 8970824935538688-3796097900216320
[
l. 4'.2., 2.
]
Expand All @@ -144,7 +144,7 @@ exports[`Snapshot 1`] = `
<span
class="reference-popover__citation"
>
Hall & Reid, 2090: 7020923936833536-4895425479835648
Hall & Reid, 2091: 7020923936833536-4895425479835648
[
l. 4'.2., 3'.
]
Expand Down Expand Up @@ -5851,9 +5851,9 @@ exports[`Snapshot 1`] = `
class="fragment-result__fragment-number"
>
<a
href="/fragmentarium/hapbig.2"
href="/fragmentarium/ewipidmif.2"
>
hapbig.2
ewipidmif.2
</a>
(JN)
</h4>
Expand All @@ -5863,15 +5863,15 @@ exports[`Snapshot 1`] = `
<small>
<p>
Accession no.:
pehuvu.2
uwhewjo.2
</p>
<p>
Excavation no.:
uf.2
gi.2
</p>
<p>
Provenance:
Ḫuzirina
Tepe Gotvand
</p>
</small>
</div>
Expand Down Expand Up @@ -5899,17 +5899,7 @@ exports[`Snapshot 1`] = `
<li
class="Record__entry"
>
Cavallini
(
Transliteration
,
<time
datetime="2061-06-11"
>
11/6/2061
</time>
)
No record
</li>
</ol>
</div>
Expand Down Expand Up @@ -5954,7 +5944,7 @@ exports[`Snapshot 1`] = `
<span
class="reference-popover__citation"
>
Checcucci & Tomlinson, 2026: 4727451873705984-8024100712742912
Checcucci & Tomlinson, 2027: 4727451873705984-8024100712742912
[
l. 3'., 1.
]
Expand All @@ -5973,14 +5963,14 @@ exports[`Snapshot 1`] = `
<span
class="reference-popover__citation"
>
Chirici & Borchi, 2055: 851575803215872-8906036102561792
Chirici & Borchi, 2110: 7824054333472768-2832266722017280
[
l. 1., 2.
l. 3'., 4'.2.
]
<span
class="type-abbreviation"
>
(D)
(E)
</span>
</span>
</li>
Expand Down
15 changes: 15 additions & 0 deletions src/fragmentarium/ui/info/ExternalNumberLink.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,21 @@ export function NabuccoLink({ number }: { number: string }): JSX.Element {
/>
)
}
export function DigitaleKeilschriftBibliothekLink({
number,
}: {
number: string
}): JSX.Element {
return (
<ExternalNumberLink
number={number}
baseUrl={
'https://gwdu64.gwdg.de/pls/tlinnemann/keilpublic_1$tafel.QueryViewByKey?'
}
label={'Digitale Keilschrift Bibliothek'}
/>
)
}
export function MetropolitanLink({ number }: { number: string }): JSX.Element {
return (
<ExternalNumberLink
Expand Down
8 changes: 8 additions & 0 deletions src/fragmentarium/ui/info/ExternalResources.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ const hilprechtJenaNumber = 'H42'
const hilprechtHeidelbergNumber = 'H007'
const achemenetNumber = 'H00744'
const nabuccoNumber = 'H00765'
const digitaleKeilschriftBibliothekNumber = 'H00765'
const metropolitanNumber = 'M123'
const louvreNumber = 'L123'
const dublinTcdNumber = 'L123'
Expand Down Expand Up @@ -43,6 +44,7 @@ describe('external resources', () => {
hilprechtHeidelbergNumber,
achemenetNumber,
nabuccoNumber,
digitaleKeilschriftBibliothekNumber,
metropolitanNumber,
louvreNumber,
dublinTcdNumber,
Expand Down Expand Up @@ -88,6 +90,11 @@ describe('external resources', () => {
'https://nabucco.acdh.oeaw.ac.at/archiv/tablet/detail/',
nabuccoNumber,
],
[
'Digitale Keilschrift Bibliothek',
'https://gwdu64.gwdg.de/pls/tlinnemann/keilpublic_1$tafel.QueryViewByKey?',
digitaleKeilschriftBibliothekNumber,
],
[
'The Metropolitan Museum of Art',
'https://www.metmuseum.org/art/collection/search/',
Expand Down Expand Up @@ -152,6 +159,7 @@ describe('missing external resources', () => {
'Hilprecht Collection – HeiCuBeDa',
'Achemenet',
'NaBuCCo',
'Digitale Keilschrift Bibliothek',
'The Metropolitan Museum of Art',
'Louvre',
'Trinity College Dublin',
Expand Down
5 changes: 5 additions & 0 deletions src/fragmentarium/ui/info/ExternalResources.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import {
HilprechtHeidelbergLink,
AchemenetLink,
NabuccoLink,
DigitaleKeilschriftBibliothekLink,
MetropolitanLink,
LouvreLink,
dublinTcdLink,
Expand Down Expand Up @@ -53,6 +54,10 @@ export default function ExternalResources({
],
[fragment.getExternalNumber('achemenetNumber'), AchemenetLink],
[fragment.getExternalNumber('nabuccoNumber'), NabuccoLink],
[
fragment.getExternalNumber('digitaleKeilschriftBibliothekNumber'),
DigitaleKeilschriftBibliothekLink,
],
[fragment.getExternalNumber('metropolitanNumber'), MetropolitanLink],
[fragment.getExternalNumber('louvreNumber'), LouvreLink],
[fragment.getExternalNumber('dublinTcdNumber'), dublinTcdLink],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,18 @@ exports[`external resources Snapshot 1`] = `
</a>
)
</li>
<li>
Digitale Keilschrift Bibliothek (
<a
aria-label="Digitale Keilschrift Bibliothek text H00765"
href="https://gwdu64.gwdg.de/pls/tlinnemann/keilpublic_1$tafel.QueryViewByKey?H00765"
rel="noopener noreferrer"
target="_blank"
>
H00765
</a>
)
</li>
<li>
The Metropolitan Museum of Art (
<a
Expand Down
Loading

0 comments on commit 519fc75

Please sign in to comment.