Filter Indirect Joins (#463)

* add functioning prototype of excludeIndirectJoins functions * redesign duplicate detection - the typecast in l. 50 is necessary to bribe TS into compiling - on usage of xor, see lodash/lodash#4852 * redesign duplicate detection - the typecast in l. 50 is necessary to bribe TS into compiling - on usage of xor, see lodash/lodash#4852 * refactor th components * Revert "refactor th components" This reverts commit 6a5eca6.
ElectronicBabylonianLiterature · Mar 12, 2024 · 5cdd5a6 · 5cdd5a6
1 parent 4511ee8
commit 5cdd5a6
Showing 1 changed file with 73 additions and 39 deletions.
diff --git a/src/corpus/ui/Chapters.tsx b/src/corpus/ui/Chapters.tsx
@@ -18,6 +18,8 @@ import { ChapterId } from 'transliteration/domain/chapter-id'
 import './Chapters.sass'
 import ManuscriptJoins from './ManuscriptJoins'
 import ManuscriptReferences from './ManuscriptReferences'
+import produce, { castDraft } from 'immer'
+import { Join } from 'fragmentarium/domain/join'
 
 function ProvenanceHeading({
   id,
@@ -40,6 +42,34 @@ function ProvenanceHeading({
   )
 }
 
+function excludeIndirectJoins(manuscripts: Manuscript[]): Manuscript[] {
+  type JoinGroup = readonly Join[]
+  const uniqueJoinGroups: JoinGroup[] = _(manuscripts)
+    .flatMap('joins')
+    .map((join) => [join])
+    .thru((values) => _.xorWith(...(values as [JoinGroup[]]), _.isEqual))
+    .value()
+
+  function isUniqueJoin(other: JoinGroup): boolean {
+    return _.some(uniqueJoinGroups, (group) => _.isEqual(group, other))
+  }
+
+  return manuscripts.map((manuscript) =>
+    produce(manuscript, (draft) => {
+      function isPrimaryJoin(joins: JoinGroup): boolean {
+        return _.some(
+          joins.map((join) => join.museumNumber === manuscript.museumNumber)
+        )
+      }
+      draft.joins = castDraft(
+        manuscript.joins.filter(
+          (joinGroup) => isPrimaryJoin(joinGroup) || isUniqueJoin(joinGroup)
+        )
+      )
+    })
+  )
+}
+
 const Manuscripts = withData<
   {
     uncertainFragments: readonly UncertainFragment[]
@@ -121,46 +151,50 @@ const Manuscripts = withData<
                   <ProvenanceHeading id={provenanceId}>
                     {provenance}
                   </ProvenanceHeading>
-                  {manuscripts.map((manuscript, index) => {
-                    const rowId = _.uniqueId('row-')
-                    return (
-                      <tr key={`${provenance} ${index}`}>
-                        <th
-                          id={rowId}
-                          headers={[provenanceId, siglumId].join(' ')}
-                          scope="row"
-                          className="list-of-manuscripts__siglum-heading"
-                        >
-                          {manuscript.siglum}
-                        </th>
-                        <td
-                          headers={[provenanceId, rowId, museumNumberId].join(
-                            ' '
-                          )}
-                          className="list-of-manuscripts__museum-numbers"
-                        >
-                          <ManuscriptJoins manuscript={manuscript} />
-                          <ManuscriptReferences
-                            references={manuscript.references}
-                          />
-                        </td>
-                        <td
-                          headers={[extantLinesId, rowId, museumNumberId].join(
-                            ' '
-                          )}
-                          className="list-of-manuscripts__extant-lines"
-                        >
-                          {extantLines ? (
-                            <ExtantLinesList
-                              extantLines={extantLines[manuscript.siglum]}
+                  {excludeIndirectJoins(manuscripts).map(
+                    (manuscript, index) => {
+                      const rowId = _.uniqueId('row-')
+                      return (
+                        <tr key={`${provenance} ${index}`}>
+                          <th
+                            id={rowId}
+                            headers={[provenanceId, siglumId].join(' ')}
+                            scope="row"
+                            className="list-of-manuscripts__siglum-heading"
+                          >
+                            {manuscript.siglum}
+                          </th>
+                          <td
+                            headers={[provenanceId, rowId, museumNumberId].join(
+                              ' '
+                            )}
+                            className="list-of-manuscripts__museum-numbers"
+                          >
+                            <ManuscriptJoins manuscript={manuscript} />
+                            <ManuscriptReferences
+                              references={manuscript.references}
                             />
-                          ) : (
-                            <Spinner />
-                          )}
-                        </td>
-                      </tr>
-                    )
-                  })}
+                          </td>
+                          <td
+                            headers={[
+                              extantLinesId,
+                              rowId,
+                              museumNumberId,
+                            ].join(' ')}
+                            className="list-of-manuscripts__extant-lines"
+                          >
+                            {extantLines ? (
+                              <ExtantLinesList
+                                extantLines={extantLines[manuscript.siglum]}
+                              />
+                            ) : (
+                              <Spinner />
+                            )}
+                          </td>
+                        </tr>
+                      )
+                    }
+                  )}
                 </React.Fragment>
               )
             })