added envelope property for joins (#440)

* added envelope property for joins * Refactoring * Added isEnvelope property to test
ElectronicBabylonianLiterature · Feb 2, 2024 · 81193c9 · 81193c9
1 parent cea2d7f
commit 81193c9
Show file tree

Hide file tree

Showing 6 changed files with 24 additions and 6 deletions.
diff --git a/src/fragmentarium/domain/Fragment.test.ts b/src/fragmentarium/domain/Fragment.test.ts
@@ -42,6 +42,7 @@ const config: Parameters<typeof Fragment['create']>[0] = {
         note: '',
         legacyData: '',
         isInFragmentarium: true,
+        isEnvelope: true,
       },
     ],
   ],

diff --git a/src/fragmentarium/domain/join.ts b/src/fragmentarium/domain/join.ts
@@ -6,6 +6,7 @@ export interface Join {
   readonly note: string
   readonly legacyData: string
   readonly isInFragmentarium: boolean
+  readonly isEnvelope: boolean
 }
 
 export type Joins = ReadonlyArray<ReadonlyArray<Join>>
diff --git a/src/fragmentarium/ui/info/Details.test.tsx b/src/fragmentarium/ui/info/Details.test.tsx
@@ -78,6 +78,7 @@ describe('All details', () => {
             [
               joinFactory.build({ isInFragmentarium: false }),
               joinFactory.build({ isInFragmentarium: true }),
+              joinFactory.build({ isEnvelope: true }),
             ],
           ],
         },
@@ -102,6 +103,12 @@ describe('All details', () => {
     ).toBeInTheDocument()
   })
 
+  it(`Renders envelope icon for joins`, () => {
+    expect(screen.queryAllByLabelText('envelope icon').length).toBeGreaterThan(
+      0
+    )
+  })
+
   it('Does not link to self', () => {
     fragment.joins
       .flat()

diff --git a/src/fragmentarium/ui/info/Details.tsx b/src/fragmentarium/ui/info/Details.tsx
@@ -44,14 +44,17 @@ function Joins({ fragment: { number, joins } }: Props): JSX.Element {
                 className="Details-joins__join"
                 key={`${groupIndex}-${index}`}
               >
-                {index > 0 ? (
-                  <>
-                    <br />+{!join.isChecked && <sup>?</sup>}
-                  </>
-                ) : groupIndex > 0 ? (
+                {index > 0 || groupIndex > 0 ? (
                   <>
                     <br />
-                    (+{!join.isChecked && <sup>?</sup>})
+                    {join.isEnvelope ? (
+                      <i
+                        className="fa fa-envelope"
+                        aria-label="envelope icon"
+                      ></i>
+                    ) : (
+                      <>+{!join.isChecked && <sup>?</sup>}</>
+                    )}
                   </>
                 ) : (
                   ''

diff --git a/src/test-support/join-fixtures.ts b/src/test-support/join-fixtures.ts
@@ -21,6 +21,7 @@ export const joinDtoFactory = Factory.define<
     note: chance.sentence(),
     legacyData: chance.sentence(),
     isInFragmentarium: chance.bool(),
+    isEnvelope: chance.bool(),
   }
 })
 
@@ -32,4 +33,5 @@ export const joinFactory = Factory.define<Join>(({ sequence }) => ({
   note: defaultChance.sentence(),
   legacyData: defaultChance.sentence(),
   isInFragmentarium: defaultChance.bool(),
+  isEnvelope: defaultChance.bool(),
 }))
diff --git a/src/test-support/test-fragment.ts b/src/test-support/test-fragment.ts
@@ -343,6 +343,7 @@ export const fragmentDto: FragmentDto = {
         note: '',
         legacyData: '',
         isInFragmentarium: true,
+        isEnvelope: true,
       },
     ],
     [
@@ -358,6 +359,7 @@ export const fragmentDto: FragmentDto = {
         note: '',
         legacyData: '',
         isInFragmentarium: false,
+        isEnvelope: true,
       },
     ],
   ],
@@ -440,6 +442,7 @@ export const fragment = new Fragment(
         note: '',
         legacyData: '',
         isInFragmentarium: true,
+        isEnvelope: true,
       },
     ],
     [
@@ -451,6 +454,7 @@ export const fragment = new Fragment(
         note: '',
         legacyData: '',
         isInFragmentarium: false,
+        isEnvelope: true,
       },
     ],
   ],