Skip to content

Commit

Permalink
Remove deprecated editedInOraccProject
Browse files Browse the repository at this point in the history
  • Loading branch information
fsimonjetz committed Dec 5, 2023
1 parent 81dc2b6 commit f6da0bf
Show file tree
Hide file tree
Showing 8 changed files with 46 additions and 69 deletions.
1 change: 0 additions & 1 deletion src/fragmentarium/domain/Fragment.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,6 @@ const config: Parameters<typeof Fragment['create']>[0] = {
{ category: ['ARCHIVAL', 'Administrative'], uncertain: false },
{ category: ['CATALOGUE', 'Memos'], uncertain: true },
]),
editedInOraccProject: 'ccp',
introduction: {
text: 'The introduction',
parts: [{ text: 'The introduction', type: 'StringPart' }],
Expand Down
1 change: 0 additions & 1 deletion src/fragmentarium/domain/FragmentDtos.ts
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@ export type ExternalNumbers = {
export default interface FragmentDto {
museumNumber: MuseumNumber
accession: MuseumNumber | null
editedInOraccProject: string
publication: string
description: string
collection: string
Expand Down
4 changes: 0 additions & 4 deletions src/fragmentarium/domain/fragment.ts
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,6 @@ export class Fragment {
readonly atf: string,
readonly hasPhoto: boolean,
readonly genres: Genres,
readonly editedInOraccProject: string,
readonly introduction: Introduction,
readonly script: Script,
readonly externalNumbers: ExternalNumbers,
Expand Down Expand Up @@ -129,7 +128,6 @@ export class Fragment {
atf,
hasPhoto,
genres,
editedInOraccProject,
introduction,
script,
externalNumbers,
Expand Down Expand Up @@ -157,7 +155,6 @@ export class Fragment {
atf: string
hasPhoto: boolean
genres: Genres
editedInOraccProject: string
introduction: Introduction
script: Script
externalNumbers: ExternalNumbers
Expand Down Expand Up @@ -186,7 +183,6 @@ export class Fragment {
atf,
hasPhoto,
genres,
editedInOraccProject,
introduction,
script,
externalNumbers,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ exports[`Snapshot 1`] = `
>
tichi.1
</a>
(Fara)
(PElam)
</h4>
<small>
<p
Expand All @@ -33,7 +33,7 @@ exports[`Snapshot 1`] = `
</p>
<p>
Excavation no.:
noj.1
radjo.1
</p>
</small>
</div>
Expand Down Expand Up @@ -5827,22 +5827,22 @@ exports[`Snapshot 1`] = `
class="fragment-result__fragment-number"
>
<a
href="/fragmentarium/cowjofke.2"
href="/fragmentarium/rikeluco.2"
>
cowjofke.2
rikeluco.2
</a>
(Unc)
(Ur3)
</h4>
<small>
<p
class="fragment-result__accession"
>
Accession no.:
ed.2
jofkeku.2
</p>
<p>
Excavation no.:
pole.2
wu.2
</p>
</small>
</div>
Expand Down Expand Up @@ -5899,14 +5899,14 @@ exports[`Snapshot 1`] = `
<span
class="reference-popover__citation"
>
Checcucci & Tomlinson, 2025: 4727451873705984-8024100712742912
White & Manca, 2070: 6525764484726784-1000123435843584
[
l. 3'., 1.
l. 3'., 2.
]
<span
class="type-abbreviation"
>
(C)
(T)
</span>
</span>
</li>
Expand All @@ -5918,14 +5918,14 @@ exports[`Snapshot 1`] = `
<span
class="reference-popover__citation"
>
Chirici & Borchi, 2108: 7541452181602304-6009873588289536
Martinez & Robin, 2112: 5946678584541184-5595938733162496
[
l. 3'., 4'.2.
]
<span
class="type-abbreviation"
>
(E)
(D)
</span>
</span>
</li>
Expand Down
4 changes: 0 additions & 4 deletions src/fragmentarium/ui/info/Details.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,6 @@ describe('Missing details', () => {
{
collection: '',
accession: '',
editedInOraccProject: '',
},
{
associations: {
Expand All @@ -177,9 +176,6 @@ describe('Missing details', () => {
it('Does not render colection', () =>
expect(screen.queryByText('Collection')).not.toBeInTheDocument())

it('Does not render editedInOraccProject', () =>
expect(screen.queryByText('EditedInOraccProject')).not.toBeInTheDocument())

it(`Renders dash for joins`, () => {
expect(screen.getByText(/Joins:/)).toHaveTextContent('-')
})
Expand Down
Loading

0 comments on commit f6da0bf

Please sign in to comment.