Skip to content

Commit

Permalink
Add Markdown to Old Siglum and remove abbreviation (#436)
Browse files Browse the repository at this point in the history
  • Loading branch information
ejimsan authored Jan 29, 2024
1 parent 09eb22d commit ffe1106
Show file tree
Hide file tree
Showing 3 changed files with 31 additions and 18 deletions.
4 changes: 4 additions & 0 deletions src/corpus/ui/ManuscriptPopover.sass
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@
@include ebl-font
&__header
font-weight: bold
&__old-sigla
font-weight: normal
.type-abbreviation
display: none
&__body p
margin-bottom: .5rem
&__provenance
Expand Down
13 changes: 8 additions & 5 deletions src/corpus/ui/ManuscriptPopover.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import { OldSiglum } from 'corpus/domain/manuscript'
import ManuscriptJoins from './ManuscriptJoins'
import ManuscriptReferences from './ManuscriptReferences'
import Citation from 'bibliography/ui/Citation'
import { Markdown } from 'common/Markdown'

function OldSiglumList({
siglumList,
Expand All @@ -19,12 +20,14 @@ function OldSiglumList({
{siglumList.map((oldSiglum, index) => (
<React.Fragment key={index}>
{index > 0 && '; '}
{oldSiglum.siglum}
{/* add bibliography info popover here */}
<span className="manuscript-popover__old-sigla__bibliography">
<Markdown text={oldSiglum.siglum} />
{/* add bibliography info popover here */}

<sup>
<Citation reference={oldSiglum.reference} />
</sup>
<sup>
<Citation reference={oldSiglum.reference} />
</sup>
</span>
</React.Fragment>
))}
)
Expand Down
32 changes: 19 additions & 13 deletions src/corpus/ui/__snapshots__/ManuscriptPopover.test.tsx.snap
Original file line number Diff line number Diff line change
Expand Up @@ -9,22 +9,28 @@ exports[`Show manuscript line details 1`] = `
class="manuscript-popover__old-sigla"
>
 (
fuwriv
<sup>
<span
class="reference-popover__citation"
>
Estrada & Wolfe, 2069: 7477711662481408-4847418310918144
[
l. 4'.2., 3'.
]
<span
class="manuscript-popover__old-sigla__bibliography"
>
<span>
fuwriv
</span>
<sup>
<span
class="type-abbreviation"
class="reference-popover__citation"
>
(C)
Estrada & Wolfe, 2069: 7477711662481408-4847418310918144
[
l. 4'.2., 3'.
]
<span
class="type-abbreviation"
>
(C)
</span>
</span>
</span>
</sup>
</sup>
</span>
)
</span>
</h3>
Expand Down

0 comments on commit ffe1106

Please sign in to comment.