Date converter form #395
Date converter form #395
Conversation
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| copyToClipboard: () => Promise<void> | ||
| } | ||
|
|
||
| function useConverterForm(): ConverterFormParams { |
There was a problem hiding this comment.
Function useConverterForm has 26 lines of code (exceeds 25 allowed). Consider refactoring.
| } | ||
| } | ||
|
|
||
| function DateConverterForm(): JSX.Element { |
There was a problem hiding this comment.
Function DateConverterForm has 37 lines of code (exceeds 25 allowed). Consider refactoring.
| }) | ||
| } | ||
|
|
||
| function getDayInputGroup(props: InputGroupsProps): JSX.Element { |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| @@ -237,39 +207,50 @@ function getDateInputGroup({ | |||
| ) | |||
| } | |||
|
|
|||
| function getYearInputGroup(props: InputGroupsProps): JSX.Element { | |||
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| copyToClipboard: () => Promise<void> | ||
| } | ||
|
|
||
| function useConverterForm(): ConverterFormParams { |
There was a problem hiding this comment.
Function useConverterForm has 27 lines of code (exceeds 25 allowed). Consider refactoring.
src/chronology/domain/DateBase.ts
Outdated
| if (this.king?.date) { | ||
| return this.getKingDate(year) | ||
| } | ||
| return '' |
There was a problem hiding this comment.
Avoid too many return statements within this function.
src/chronology/domain/DateBase.ts
Outdated
| this.ur3Calendar = ur3Calendar | ||
| } | ||
|
|
||
| toJulianDate(): string { |
There was a problem hiding this comment.
Function toJulianDate has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
| @@ -0,0 +1,278 @@ | |||
| import { MesopotamianDate } from 'chronology/domain/Date' | |||
There was a problem hiding this comment.
File DateSelectionState.ts has 257 lines of code (exceeds 250 allowed). Consider refactoring.
| if (field.name === 'seBabylonianYear') { | ||
| return getSeBabylonianYearOptions() | ||
| } | ||
| return [] |
There was a problem hiding this comment.
Avoid too many return statements within this function.
| } from 'chronology/domain/DateConverterBase' | ||
| import { Field } from 'chronology/application/DateConverterFormFieldData' | ||
|
|
||
| export default function getOptions({ |
There was a problem hiding this comment.
Function getOptions has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
| : [] | ||
| } | ||
|
|
||
| const getYearOptions = (field: Field): JSX.Element[] => { |
There was a problem hiding this comment.
Function getYearOptions has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
| return [] | ||
| } | ||
|
|
||
| const getDayOptions = ( |
There was a problem hiding this comment.
Function getDayOptions has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
|
Code Climate has analyzed commit 32e3d43 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 93.0% (75% is the threshold). This pull request will bring the total coverage in the repository to 91.0% (0.0% change). View more on Code Climate. |
No description provided.