Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date fixes #448

Merged
merged 108 commits into from
Feb 23, 2024
Merged

Date fixes #448

merged 108 commits into from
Feb 23, 2024

Conversation

khoidt
Copy link
Contributor

@khoidt khoidt commented Feb 12, 2024

No description provided.

@@ -44,6 +44,12 @@ describe('DatesInTextSelection', () => {
await act(async () => {
fireEvent.click(addButton)
})
const dayInput = screen.getByPlaceholderText('Day')
const monthInput = screen.getByPlaceholderText('Month')
await act(async () => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Identical blocks of code found in 2 locations. Consider refactoring.

@@ -62,6 +68,12 @@
await act(async () => {
fireEvent.click(editButton)
})
const dayInput = screen.getByPlaceholderText('Day')
const monthInput = screen.getByPlaceholderText('Month')
await act(async () => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Identical blocks of code found in 2 locations. Consider refactoring.

Copy link

codeclimate bot commented Feb 22, 2024

Code Climate has analyzed commit 29d3eab and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 89.6% (75% is the threshold).

This pull request will bring the total coverage in the repository to 91.1% (0.0% change).

View more on Code Climate.

@khoidt khoidt merged commit 8149b4b into master Feb 23, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant