Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newsletter section #450

Merged
merged 17 commits into from
Feb 21, 2024
Merged

Newsletter section #450

merged 17 commits into from
Feb 21, 2024

Conversation

zsomborfoldi
Copy link
Contributor

No description provided.

import Markup from 'markup/ui/markup'
import MarkupService from 'markup/application/MarkupService'

export default function AboutNews(markupService: MarkupService): JSX.Element {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function AboutNews has 110 lines of code (exceeds 25 allowed). Consider refactoring.

import Markup from 'markup/ui/markup'
import MarkupService from 'markup/application/MarkupService'

export default function AboutNews(markupService: MarkupService): JSX.Element {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function AboutNews has 123 lines of code (exceeds 25 allowed). Consider refactoring.

import Markup from 'markup/ui/markup'
import MarkupService from 'markup/application/MarkupService'

export default function AboutNews(markupService: MarkupService): JSX.Element {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function AboutNews has 124 lines of code (exceeds 25 allowed). Consider refactoring.

@zsomborfoldi zsomborfoldi requested a review from khoidt February 15, 2024 13:37
Copy link

codeclimate bot commented Feb 21, 2024

Code Climate has analyzed commit cfedd61 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 88.8% (75% is the threshold).

This pull request will bring the total coverage in the repository to 91.1% (0.0% change).

View more on Code Climate.

@khoidt khoidt merged commit a4249cb into master Feb 21, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants