-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Newsletter section #450
Newsletter section #450
Conversation
src/about/ui/news.tsx
Outdated
import Markup from 'markup/ui/markup' | ||
import MarkupService from 'markup/application/MarkupService' | ||
|
||
export default function AboutNews(markupService: MarkupService): JSX.Element { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function AboutNews
has 110 lines of code (exceeds 25 allowed). Consider refactoring.
src/about/ui/news.tsx
Outdated
import Markup from 'markup/ui/markup' | ||
import MarkupService from 'markup/application/MarkupService' | ||
|
||
export default function AboutNews(markupService: MarkupService): JSX.Element { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function AboutNews
has 123 lines of code (exceeds 25 allowed). Consider refactoring.
src/about/ui/news.tsx
Outdated
import Markup from 'markup/ui/markup' | ||
import MarkupService from 'markup/application/MarkupService' | ||
|
||
export default function AboutNews(markupService: MarkupService): JSX.Element { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function AboutNews
has 124 lines of code (exceeds 25 allowed). Consider refactoring.
Code Climate has analyzed commit cfedd61 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 88.8% (75% is the threshold). This pull request will bring the total coverage in the repository to 91.1% (0.0% change). View more on Code Climate. |
No description provided.