Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alalakh HPM #451

Merged
merged 8 commits into from
Feb 14, 2024
Merged

Alalakh HPM #451

merged 8 commits into from
Feb 14, 2024

Conversation

ejimsan
Copy link
Member

@ejimsan ejimsan commented Feb 14, 2024

No description provided.

import Markup from 'markup/ui/markup'
import MarkupService from 'markup/application/MarkupService'

export default function AboutNews(markupService: MarkupService): JSX.Element {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function AboutNews has 110 lines of code (exceeds 25 allowed). Consider refactoring.

Copy link

codeclimate bot commented Feb 14, 2024

Code Climate has analyzed commit b5e129c and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (75% is the threshold).

This pull request will bring the total coverage in the repository to 91.1% (0.0% change).

View more on Code Climate.

@ejimsan ejimsan merged commit 26cb74a into master Feb 14, 2024
12 checks passed
@ejimsan ejimsan deleted the alalakh-hpm branch February 14, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants