Colophons #462
Colophons #462
Conversation
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| ) | ||
| } | ||
|
|
||
| function ArchaeologyContents(props: TabsProps): JSX.Element { |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| ) | ||
| } | ||
|
|
||
| function ColophonContents(props: TabsProps): JSX.Element { |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| }[name]() | ||
| } | ||
|
|
||
| function isTabDisabled({ |
There was a problem hiding this comment.
Similar blocks of code found in 3 locations. Consider refactoring.
| ) | ||
| } | ||
|
|
||
| function DisplayContents(props: TabsProps): JSX.Element { |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
src/colophons/ui/ColophonEditor.tsx
Outdated
| isUncertain: boolean | ||
| } | ||
|
|
||
| interface Individual { |
There was a problem hiding this comment.
Similar blocks of code found in 3 locations. Consider refactoring.
src/colophons/ui/ColophonEditor.tsx
Outdated
| OnlyColophon = 'Only Colophon', | ||
| } | ||
|
|
||
| enum ColophonType { |
There was a problem hiding this comment.
Identical blocks of code found in 2 locations. Consider refactoring.
src/colophons/ui/ColophonEditor.tsx
Outdated
| value={individual.name?.value ?? ''} | ||
| onChange={(e) => onUpdate('name', 'value', e.target.value)} | ||
| /> | ||
| <Form.Control |
There was a problem hiding this comment.
Similar blocks of code found in 3 locations. Consider refactoring.
| isUncertain: boolean | ||
| } | ||
|
|
||
| export interface Individual { |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| return `${chance.sentence()}\n${chance.sentence()}` | ||
| } | ||
|
|
||
| export function fragmentCollection( |
There was a problem hiding this comment.
Function fragmentCollection has 30 lines of code (exceeds 25 allowed). Consider refactoring.
| }: BrokenUncertainProps): JSX.Element { | ||
| return ( | ||
| <> | ||
| <Form.Switch |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| onChange={(event) => setBroken(event.target.checked)} | ||
| checked={isBroken} | ||
| /> | ||
| <Form.Switch |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| @@ -0,0 +1,277 @@ | |||
| import React from 'react' | |||
There was a problem hiding this comment.
File ColophonEditorInputs.tsx has 266 lines of code (exceeds 250 allowed). Consider refactoring.
| const _individuals = | ||
| individuals.length > 0 ? individuals : [new IndividualAttestation()] | ||
| return ( | ||
| <ListForm |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| ) | ||
| } | ||
|
|
||
| export const ColophonStatusInput = ({ |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| ) | ||
| } | ||
|
|
||
| export const ColophonOwnershipInput = ({ |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| }) | ||
| } | ||
|
|
||
| setTypeField(type?: IndividualTypeAttestation): IndividualAttestation { |
There was a problem hiding this comment.
Similar blocks of code found in 5 locations. Consider refactoring.
| index: number | ||
| }): JSX.Element => { | ||
| const nameFields = ['name', 'sonOf', 'grandsonOf', 'family'] | ||
| const getSelectField = (props, key: string) => { |
There was a problem hiding this comment.
Function getSelectField has 45 lines of code (exceeds 25 allowed). Consider refactoring.
| } | ||
| } | ||
|
|
||
| const IndividualForm = ({ |
There was a problem hiding this comment.
Function IndividualForm has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
| }) | ||
| } | ||
|
|
||
| toString(): string { |
There was a problem hiding this comment.
Function toString has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
| }) | ||
| } | ||
| } | ||
| const individualFields = [...nameFields, 'nativeOf', 'type'].map((key) => { |
There was a problem hiding this comment.
Function individualFields has 39 lines of code (exceeds 25 allowed). Consider refactoring.
| @@ -0,0 +1,336 @@ | |||
| import React, { useState } from 'react' | |||
There was a problem hiding this comment.
File ColophonEditor.tsx has 307 lines of code (exceeds 250 allowed). Consider refactoring.
|
Code Climate has analyzed commit 8afc586 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 89.9% (75% is the threshold). This pull request will bring the total coverage in the repository to 91.0% (0.0% change). View more on Code Climate. |
No description provided.