Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change eBL Logo, Add Akademie Logo #487

Merged
merged 4 commits into from
Jul 3, 2024
Merged

Change eBL Logo, Add Akademie Logo #487

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3cbc58d
Change eBL Logo, Add Akademie Logo
ejimsan Jul 2, 2024
986c24d
Refactor
ejimsan Jul 3, 2024
7cf53a2
Refactor and redo introduction
ejimsan Jul 3, 2024
f21ecbb
Correct lint issues
ejimsan Jul 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
86 changes: 86 additions & 0 deletions src/BAdW_Logo.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
32 changes: 21 additions & 11 deletions src/Header.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,28 +1,38 @@
.Header__corporate-logo {
height: 4em;
margin-bottom: 0.5rem;
.Header__badw-logo {
height: 1.7em;
}

.Header__lmu-logo {
height: 2em;
margin-bottom: -0.3em;
}

.Header__logo-container {
display: flex;
flex-direction: column;
text-align: center;
}

.Header__title {
font-size: 1em;
}

.Header__title-main {
border-right: 0.05em solid black;
display: inline-block;
font-weight: bold;
line-height: 1.2;
margin-right: 0.5em;
padding-right: 0.5em;
text-align: right;
font-variant: unicase;
vertical-align: middle;
}

.Header__title-abbreviation {
color: white;
font-size: 4em;
line-height: 0.7;
text-shadow: -1.5px -1px 0 black, 1px -1px 0 black, -1px 1px 0 black,
1px 1px 0 black;
font-size: 3em;
font-variant: unicase;
padding: 0 0.1em 0 0.1em;
background-color: #0077be;
vertical-align: middle;
margin-right: 0.2em;
}

#navbar-container {
Expand Down
18 changes: 13 additions & 5 deletions src/Header.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import _ from 'lodash'
import User from './auth/User'
import './Header.css'
import lmuLogo from './LMU_Logo.svg'
import badwLogo from './BAdW_Logo.svg'
import ExternalLink from 'common/ExternalLink'

function EblLogo(): JSX.Element {
Expand Down Expand Up @@ -40,11 +41,6 @@ export default function Header(): JSX.Element {
<header className="Header">
<Navbar variant="light" expand="md">
<Container>
<Navbar.Brand>
<ExternalLink href="https://www.lmu.de">
<Image className="Header__corporate-logo" src={lmuLogo} fluid />
</ExternalLink>
</Navbar.Brand>
<LinkContainer
to="/"
title="electronic Babylonian Library (eBL)"
Expand All @@ -54,6 +50,18 @@ export default function Header(): JSX.Element {
<EblLogo />
</Navbar.Brand>
</LinkContainer>
<div className="Header__logo-container">
<Navbar.Brand>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 2 locations. Consider refactoring.

<ExternalLink href="https://www.lmu.de">
<Image className="Header__lmu-logo" src={lmuLogo} fluid />
</ExternalLink>
</Navbar.Brand>
<Navbar.Brand>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 2 locations. Consider refactoring.

<ExternalLink href="https://badw.de/">
<Image className="Header__badw-logo" src={badwLogo} fluid />
</ExternalLink>
</Navbar.Brand>
</div>
<Navbar.Toggle aria-controls={id} />
<Navbar.Collapse id={id}>
<div
Expand Down
Loading
Loading